This repository was archived by the owner on Nov 30, 2024. It is now read-only.
Removing code duplication in feature test#1623
Merged
Merged
Conversation
The verification on the expectors was run twice in the feature test for the integration of mocking frameworks. Tests still pass, maybe a millisecond faster.
Member
|
LGTM, build failure was due to a travis timeout. I'm sure it will pass, but I restarted it just for sanity purposes. |
Member
|
Thanks @treppo |
cupakromer
added a commit
that referenced
this pull request
Jun 29, 2014
Removing code duplication in feature test
cupakromer
pushed a commit
that referenced
this pull request
Jun 29, 2014
Removing code duplication in feature test The verification on the expectors was run twice in the feature test for the integration of mocking frameworks. Tests still pass, maybe a millisecond faster.
MatheusRich
pushed a commit
to MatheusRich/rspec-core
that referenced
this pull request
Oct 30, 2020
Removing code duplication in feature test
yujinakayama
pushed a commit
to yujinakayama/rspec-monorepo
that referenced
this pull request
Oct 6, 2021
Removing code duplication in feature test The verification on the expectors was run twice in the feature test for the integration of mocking frameworks. Tests still pass, maybe a millisecond faster. --- This commit was imported from rspec/rspec-core@64696d1.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The verification on the expectors was run twice in the feature test for the
integration of mocking frameworks. Tests still pass, maybe a millisecond faster.