This repository was archived by the owner on Nov 30, 2024. It is now read-only.
Add placeholder for code_or_symbol to NullColorizer#1637
Merged
Conversation
Member
|
Oops, can you add a spec for this please. |
Contributor
Author
|
Sure. I'm not accustomed to RSpec-core's test habit. |
Member
There was a problem hiding this comment.
I'd prefer if ignored was called _code_or_symbol. The _ is a hint to ruby that it's an ignored variable, and giving it a name related to the wrap signature it is aligning with helps make it clearer.
Contributor
Author
There was a problem hiding this comment.
I agree. Thank you for good advice.
0f21818
Member
|
One last fix and then if you could squash these commits this will be good to go IMO. |
Contributor
Author
|
All done. |
Member
|
Thanks @tomykaira |
JonRowe
added a commit
that referenced
this pull request
Jul 19, 2014
Add placeholder for code_or_symbol to NullColorizer
JonRowe
added a commit
that referenced
this pull request
Jul 19, 2014
Add placeholder for code_or_symbol to NullColorizer
Member
|
Cherry-picked to |
MatheusRich
pushed a commit
to MatheusRich/rspec-core
that referenced
this pull request
Oct 30, 2020
Add placeholder for code_or_symbol to NullColorizer
MatheusRich
pushed a commit
to MatheusRich/rspec-core
that referenced
this pull request
Oct 30, 2020
yujinakayama
pushed a commit
to yujinakayama/rspec-monorepo
that referenced
this pull request
Oct 6, 2021
…ap_args Add placeholder for code_or_symbol to NullColorizer --- This commit was imported from rspec/rspec-core@ba9da85.
yujinakayama
pushed a commit
to yujinakayama/rspec-monorepo
that referenced
this pull request
Oct 6, 2021
This commit was imported from rspec/rspec-core@af7f121.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The signature of
NullColorizer#wrapwas different fromConsoleCodes#wrap, therefore#message_linesraised error.