Tweak deprecation message for symbol descriptions.#1667
Conversation
There was a problem hiding this comment.
This line should be removed.
There was a problem hiding this comment.
Vim buffer error ;) the amount of time I removed this...
|
LGTM besides my comments. |
|
I'm going to merge when green, and not going to add a changelog (as it's just tweaking an existing deprecation). |
Normally I would agree with this but I plan to cut a 2.99.2 release with this later today (since we have no other planned 2.99 changes, no reason to wait...) and there are no other changes in 2-99-maintenance...so I think it's worth putting a changelog entry about improving the deprecation message. Otherwise the changelog will suggest that 2.99.2 includes no changes. |
|
Ok, I'll add one then. |
[skip ci]
Tweak deprecation message for symbol descriptions.
[skip ci] --- This commit was imported from rspec/rspec-core@0f6ce5b.
…r_symbol_deprecation Tweak deprecation message for symbol descriptions. --- This commit was imported from rspec/rspec-core@00eceeb.
2 participants
Tweak deprecation message for symbol descriptions to indicate it will effect
described_class, this should fix #1666.Note I added a spec covering this.