Adds search as a future for server-side rendering #1011
Conversation
|
|
yihui
left a comment
yihui
left a comment
There was a problem hiding this comment.
Please add a bullet to NEWS.md to mention this new feature (also feel free to add your name to DESCRIPTION as a ctb contributor). Thanks!
R/shiny.R
Outdated
| httpResponse = shinyFun('httpResponse') | ||
|
|
||
| filterFun = function(data, req) { | ||
| filterExpr = expression({ |
There was a problem hiding this comment.
Usually I don't prefer using eval(expression()) because we need to be careful about the evaluating environment. Is it okay to still make a function here, and provide a function call in promises::future_promise()?
There was a problem hiding this comment.
| filterExpr = expression({ | |
| filterFun2 = function(data, req) { |
There was a problem hiding this comment.
Sounds good to me
R/shiny.R
Outdated
| filterFun = function(data, req) { | ||
| if (identical(future, FALSE)) return(eval(filterExpr)) | ||
| else return(future_promise(seed = TRUE, { eval(filterExpr) })) |
There was a problem hiding this comment.
| filterFun = function(data, req) { | |
| if (identical(future, FALSE)) return(eval(filterExpr)) | |
| else return(future_promise(seed = TRUE, { eval(filterExpr) })) | |
| filterFun = function(data, req) { | |
| if (future) promises::future_promise(filterFun2(), seed = TRUE) else filterFun2() |
| renderDataTable = function( | ||
| expr, server = TRUE, env = parent.frame(), quoted = FALSE, | ||
| funcFilter = dataTablesFilter, ... | ||
| funcFilter = dataTablesFilter, future = FALSE, ... |
There was a problem hiding this comment.
The new argument needs to be documented.
|
I'll make the changes and document it asap |
|
Changes made! @yihui |
yihui
left a comment
yihui
left a comment
There was a problem hiding this comment.
There are a few minor changes that I'd like to make before merging. Could you allow me to edit the PR? https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/allowing-changes-to-a-pull-request-branch-created-from-a-fork Thanks!
|
I'll have to create the Pull request again. |
|
You don't really need to create a new PR. All you need to do is check the box "Allow edits by maintainers" at the bottom of the right sidebar of this page. |
3 participants
Resolves #1010