update to jszip 3.10.1 #1017
Merged
update to jszip 3.10.1 #1017
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yihui
approved these changes
Sep 9, 2022
Contributor
yihui
left a comment
yihui
left a comment
There was a problem hiding this comment.
Sounds good. Thank you!
I'll merge this PR for now. This change really needs to be done in the upstream DataTables library. We are not using the latest version of DataTables yet. I wonder if they have updated jszip there.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update jszip to 3.10.1 to address #1016.
Source of jszip: https://github.com/Stuk/jszip/blob/main/dist/jszip.min.js
I'm not really clear on how jszip is called internally, so I haven't written any sophisticated tests, just verifying that the buttons are rendered correctly. And just verified manually that the buttons are working correctly by downloading the .xlsx file as per below: