Add support for list of classes in DT2BSClass
#1089
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR seeks to bring support for a list of classes in
DT2BSClass(), with the end goal of fixing the issue #1052.In more details, when you select
style='bootstrap',DT::datatable()tries to translate theclassargument, to a css rule with all the Bootstrap classes that were mentioned in theclassargument. To make this translation, theDT2BSClass()function is called with the class argument. However, theDT2BSClass()function only supports a character vector as input.This PR will allow
DT2BSClass()to receive a list of booleans as input, as mentioned in the example from issue #1052.In essence, we use
base::Filter()to select the elements of the list that are TRUE, and simply extract the name of these filtered elements.