Skip to content

Conversation

@smlng
Copy link
Member

@smlng smlng commented Jun 20, 2016

this PR address issue #6 and updates rtr_mgr_init calls to match new RTRlib API and also adds cmake modules to find dependencies, such as libssh, and rtrlib.

This is WIP, as I haven't tested it against/with a real BIRD instance.

@waehlisch
Copy link
Member

I get a memory exception. You can check on 141.22.28.223 /prog/....

@smlng
Copy link
Member Author

smlng commented Jun 20, 2016

fixed input params, now it's working as far as I can test it.

@waehlisch
Copy link
Member

Thanks @smlng! Why was RTR_INVALID_PARAM not firing?

@smlng
Copy link
Member Author

smlng commented Jun 21, 2016

Oh it was, later on - but first I had to fix a minor memory leak in the config param parser 😄

Though, I was able to run a simple connection test with a BIRD instance (which succeeded), do we know someone with a more production-like setup for testing? Just to be certain, everything is working.

@waehlisch waehlisch merged commit 1651a02 into rtrlib:master Jun 21, 2016
@smlng smlng deleted the pr_update_to_new_rtrlib_api branch June 21, 2016 07:29
@waehlisch waehlisch mentioned this pull request Jun 21, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants