Skip to content

Implement wait_for_selector #236

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Mifrill wants to merge 13 commits into
base: main
Choose a base branch
from
Open

Implement wait_for_selector #236

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
c58767f
extend evaluate_func with any options ability
Mifrill Jan 7, 2022
83ca882
implement #wait_for_selector method for browser
Mifrill Jan 7, 2022
051617d
fix spec with hardcoded value of size for with_js view due to added l…
Mifrill Jan 7, 2022
8d98b79
increase default timeout to 5 sec
Mifrill Jan 12, 2022
0f0fbe0
add spec: 'waits for selector within frame'
Mifrill Jan 15, 2022
53edf60
returns Node instead DOM instance in wait_for_selector method
Mifrill Jan 15, 2022
cf74591
set default timeout 3 sec
Mifrill Jan 15, 2022
3b09739
fill CHANGELOG/README for implemented Ferrum::Browser#wait_for_select…
Mifrill Jan 15, 2022
c153714
apply heredoc for JS expression in Frame::DOM#wait_for_selector for c…
Mifrill Feb 1, 2022
0489d60
refactor wait_for_selector method with wait_for_css/wait_for_xpath
Mifrill Feb 1, 2022
c052bd2
cleanup: simplify arguments calls for wait_for_selector method
Mifrill Feb 1, 2022
6bd16ef
cleanup: squash wrapperFunction with findElement function in wait_for…
Mifrill Feb 1, 2022
02a2df6
Merge remote-tracking branch 'origin/main' into issue_82/implement_wa…
Mifrill Apr 19, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
set default timeout 3 sec
  • Loading branch information
@Mifrill
Mifrill committed Jan 15, 2022
commit cf74591384ffb8351befab380b1e07f00cf3f563
2 changes: 1 addition & 1 deletion lib/ferrum/frame/dom.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ def body
evaluate("document.documentElement.outerHTML")
end

def wait_for_selector(css: nil, xpath: nil, timeout: 5000, interval: 100)
def wait_for_selector(css: nil, xpath: nil, timeout: 3000, interval: 100)
evaluate_func(%(
Copy link
Contributor

@ttilberg ttilberg Feb 1, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To be more consistent with the rest of the gem, would you mind changing this to use a JS heredoc? This is helpful because many editors support code highlighting in the language specified:

Original:
image

VS:

Subl:
image

Code:
image

I haven't tried the code out yet, but I'm looking forward to this feature!

Copy link
Contributor Author

@Mifrill Mifrill Feb 1, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it makes sense, will change, thanks!

function(selector, isXpath, timeout, interval) {
var attempts = 0;
Expand Down
6 changes: 6 additions & 0 deletions spec/browser_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -530,6 +530,12 @@ module Ferrum
expect(browser.wait_for_selector(xpath: "//div[@id='wait_for_hidden_selector']")).not_to be_nil
end

it "raises error when default timeout exceed" do
expect do
browser.wait_for_selector(css: "div#not_existed_element")
end.to raise_error(Ferrum::JavaScriptError, /Not found element match the selector/)
end

it "raises error when timeout exceed" do
expect do
browser.wait_for_selector(css: "div#wait_for_selector", timeout: 800)
Expand Down