Skip to content

Document cancel-safety of FuturesUnordered::poll_next #2897

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Document cancel-safety of FuturesUnordered::poll_next #2897

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8a75b98
Document cancel-safety of FuturesUnordered::poll_next
akonradi-signal Nov 13, 2024
ea5b0ea
Conditionalize cancel-safety on Future cancel safety
akonradi-signal Dec 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Conditionalize cancel-safety on Future cancel safety
  • Loading branch information
@akonradi-signal
akonradi-signal committed Dec 2, 2024
commit ea5b0ea5414e591de23bfef32c2b8c5e640892da
9 changes: 5 additions & 4 deletions futures-util/src/stream/futures_unordered/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,10 +56,11 @@ use self::ready_to_run_queue::{Dequeue, ReadyToRunQueue};
///
/// # Cancel safety
///
/// This type is cancellation-safe. If [`poll_next`](Stream::poll_next) is
/// called (either directly or via [`crate::StreamExt::next`]) and it returns
/// [`Poll::Pending`], no values will be dropped if `poll_next` is not called
/// again.
/// This type is cancellation-safe when the inner [`Future`] is
/// cancellation-safe. If the future type is cancellation-safe, and
/// [`poll_next`](Stream::poll_next) is called (either directly or via
/// [`crate::StreamExt::next`]) and returns [`Poll::Pending`], no values will be
/// dropped if `poll_next` is not called again.
#[must_use = "streams do nothing unless polled"]
pub struct FuturesUnordered<Fut> {
ready_to_run_queue: Arc<ReadyToRunQueue<Fut>>,
Expand Down
Loading