Use custom config entry iterator. #854
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nickgerace
added a commit
to nickgerace/gfold
that referenced
this pull request
Aug 9, 2022
Primary: - Switch to cargo workspace to replace xtask, make, etc. - Add debug symbol stripping Misc: - Upgrade all packages - Replace entries iterator with "next" due to the following PR: rust-lang/git2-rs#854 - Remove "rustfmt.toml" Signed-off-by: Nick Gerace <[email protected]>
bors bot
added a commit
to nickgerace/gfold
that referenced
this pull request
Aug 9, 2022
206: Switch to cargo workspace r=nickgerace a=nickgerace Primary: - Switch to cargo workspace to replace xtask, make, etc. - Add debug symbol stripping Misc: - Upgrade all packages - Replace entries iterator with "next" due to the following PR: rust-lang/git2-rs#854 - Remove "rustfmt.toml" Fixes #207 Co-authored-by: Nick Gerace <[email protected]>
JohnFredok
added a commit
to JohnFredok/gfold
that referenced
this pull request
Oct 24, 2023
Primary: - Switch to cargo workspace to replace xtask, make, etc. - Add debug symbol stripping Misc: - Upgrade all packages - Replace entries iterator with "next" due to the following PR: rust-lang/git2-rs#854 - Remove "rustfmt.toml" Signed-off-by: Nick Gerace <[email protected]>
JohnFredok
added a commit
to JohnFredok/gfold
that referenced
this pull request
Oct 24, 2023
206: Switch to cargo workspace r=nickgerace a=nickgerace Primary: - Switch to cargo workspace to replace xtask, make, etc. - Add debug symbol stripping Misc: - Upgrade all packages - Replace entries iterator with "next" due to the following PR: rust-lang/git2-rs#854 - Remove "rustfmt.toml" Fixes #207 Co-authored-by: Nick Gerace <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This switches
ConfigEntriesto a custom iterator implementation in order to solve a lifetime problem withgit_config_next. Entries may not live between successive calls togit_config_next, so this needs to ensure that isn't allowed.Fixes #836
This is a breaking API change. I don't feel this is particularly urgent, so I'm content to let it wait until some other change motivates a version bump. However, I know some people may be more sensitive to possible memory violations, so I figured I'd at least get a patch ready.