Update for grammer using interning.
#119
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
(wrong button, sorry) |
eddyb
force-pushed
the
intern
branch
2 times, most recently
from
afd3493 to
1cd990d
Compare
eddyb
changed the title
grammer using interning.grammer using interning.
Centril
approved these changes
May 20, 2019
| grammar.extend(grammer::grammar_grammar()); | ||
| let mut cx = proc_macro::Context::new(); | ||
| let mut grammar = proc_macro::builtin(&mut cx); | ||
| grammar.extend(grammer::grammar_grammar(&mut cx)); |
Contributor
There was a problem hiding this comment.
buffalo buffalo buffalo ;)
| } | ||
|
|
||
| #[proc_macro] | ||
| pub fn proc_macro_parser(input: TokenStream) -> TokenStream { |
Contributor
There was a problem hiding this comment.
Preexisting, but could use a doc comment on the function in a follow up PR or something.
| use proc_quote::ToTokens as _; | ||
|
|
||
| #[proc_macro] | ||
| pub fn scannerless_parser(input: TokenStream) -> TokenStream { |
qmx
approved these changes
May 21, 2019
Contributor
qmx
left a comment
qmx
left a comment
There was a problem hiding this comment.
we might want to circle back and review our .unwrap() usage here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See LykenSol/grammer#4.