ctest: Replace check_same_hex with check_same_bytes #4798
Merged
+750
−219
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fyi @mbyx |
tgross35
force-pushed
the
ctest-updates
branch
3 times, most recently
from
00c632e to
dc482af
Compare
GCC flags function return values that include `volatile` even through
typedefs, such as with this example from NetBSD:
typedef unsigned char __cpu_simple_lock_nv_t;
typedef volatile __cpu_simple_lock_nv_t __cpu_simple_lock_t;
typedef __cpu_simple_lock_t pthread_spin_t;
pthread_spin_t foo() { return 0; }
Ignore the warning for the scope where we emit these tests.
tgross35
force-pushed
the
ctest-updates
branch
2 times, most recently
from
f23557a to
2e7b7ca
Compare
|
For the first commit, verified that the volatile typedef does emit the warning in #4800 |
This allows us to print the entire slice on failure rather than only a single mismatched byte. Also use this as an opportunity to quote types in failure messages. A possible future improvement here would be to check if the type is an integer in our template and call `check_same` instead if so, which would let us print the decimal value as well.
tgross35
force-pushed
the
ctest-updates
branch
from
2e7b7ca to
8a224ab
Compare
|
@rustbot label +stable-unneeded |
rustbot
added
the
stable-unneeded
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows us to print the entire slice on failure rather than only a
single mismatched byte.
A possible future improvement here would be to check if the type is an
integer in our template and call
check_sameinstead if so, which wouldlet us print the decimal value as well.