Revert "Replace mempool with thread_local" #208
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This caused regex to require Rust 1.6, which really should require a semver bump since it will break existing code. For now, we'll stick with mempool and move to the faster thread_local version on the next semver bump (hopefully 1.0). Fixes #206
Member
Author
|
cc @Amanieu I'll undo this revert on the next semver bump. Sorry about the churn. |
Closed
Member
|
Don't bother, I'm pushing an update to thread_local to make it work on 1.3. |
Member
Author
|
@Amanieu Thank you! :-) |
Member
|
r=me but if a new version of |
Member
|
Aha, #209 does that |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This caused regex to require Rust 1.6, which really should require a
semver bump since it will break existing code. For now, we'll stick with
mempool and move to the faster thread_local version on the next semver
bump (hopefully 1.0).
Fixes #206