Skip to content

Fix potential overflow bug. #227

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
BurntSushi merged 1 commit into from
May 6, 2016
Merged

Fix potential overflow bug. #227

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Fix potential overflow bug.
  • Loading branch information
@SeanRBurton
SeanRBurton committed May 6, 2016
commit ba4db227e7d0467d22f85ebbd1fee95aaea3695a
9 changes: 6 additions & 3 deletions src/dfa.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,9 +66,12 @@ use sparse::SparseSet;
pub fn can_exec(insts: &Program) -> bool {
use prog::Inst::*;
// If for some reason we manage to allocate a regex program with more
// than u32::MAX instructions, then we can't execute the DFA because we
// use 32 bit instruction pointers for memory savings.
if insts.len() > ::std::u32::MAX as usize {
// than i32::MAX instructions, then we can't execute the DFA because we
// use 32 bit instruction pointer deltas for memory savings.
// If i32::MAX is the largest positive delta,
// then -i32::MAX == i32::MIN + 1 is the largest negative delta,
// and we are OK to use 32 bits.
if insts.len() > ::std::i32::MAX as usize {
return false;
}
for inst in insts {
Expand Down