Fix SIMD Fallback Import

[killercup]

Fixes cargo doc and some other stuff.

r? @BurntSushi

[killercup]

I also added some details to the references since I was looking through the papers anyway. (It follows the APA style used by Google Scholar.)

[BurntSushi]

I think you don't actually need this cfg switch, right? The cfg switch is done in lib.rs so that simd_fallback should never actually be explicitly used.

[killercup]

You still import it as simd_fallback, though. Might be a good idea to provide a shim module in lib.rs depending on the feature flag (the shim in simd_accel only deals with the target arch feature).

[BurntSushi]

Oh, I see. I thought I was using path, but maybe it was somewhere else. Maybe this should be in lib.rs?

#[cfg(not(feature = "simd-accel"))]
#[path = "simd_fallback/mod.rs"]
mod simd_accel;

I think that would work? Or something equivalent would be fine. I was just trying to stop the use of cfg switching everywhere.

[killercup]

Yeah, that should work. Defining the shim in lib.rs is far better than using cfg here. I'll change this.

[killercup]

Rebased.

[BurntSushi]

@killercup Could you rebase this against master? Sorry for the churn. Thanks!

[killercup]

@BurntSushi no problem! Rebased on master.

[BurntSushi]

Awesome, thanks so much! :D

[BurntSushi]

@killercup Hmm, it looks like this got merged into the simd-teddy branch. Whoops. Could you resubmit against master please?

[killercup]

Oh, Github didn't change the target branch :( just one second!
Andrew Gallant [email protected] schrieb am Do., 19. Mai 2016 um
01:39:

@killercup https://github.com/killercup Hmm, it looks like this got
merged into the simd-teddy branch. Whoops. Could you resubmit against
master please?

—
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
#232 (comment)