Skip to content

Extend entry API to work on borrowed keys. #1769

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
cristicbz wants to merge 13 commits into from
Closed

Extend entry API to work on borrowed keys. #1769

Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
74391a7
add entry-into-owned rfc
cristicbz Oct 12, 2016
bf03d12
fix example in summary
cristicbz Oct 12, 2016
6952692
fix a couple typos
cristicbz Oct 12, 2016
af7dc42
add note on insta-stable and IntoOwned usefulness
cristicbz Oct 12, 2016
9e35d5e
change to AsBorrowRef version
cristicbz Oct 13, 2016
10f8b13
fix some phrasing here and there
cristicbz Oct 13, 2016
c5d9df9
add bit about deref coercions
cristicbz Oct 14, 2016
1e329b6
update with knowledge from crater
cristicbz Oct 14, 2016
eb63ff8
fix rust highlighting in deref block
cristicbz Oct 14, 2016
8f41677
order alternatives correctly with code
cristicbz Oct 14, 2016
a4b35b7
introduce another option of getting rid of B
cristicbz Oct 14, 2016
12ba17a
fix a duplicated paragraph
cristicbz Oct 15, 2016
0d027ef
change to Query and add explicit impl alternative
cristicbz Feb 28, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
add note on insta-stable and IntoOwned usefulness
  • Loading branch information
@cristicbz
cristicbz committed Oct 12, 2016
commit af7dc426fbbec98ec560d93bca8d69aa3ee799fc
6 changes: 5 additions & 1 deletion text/0000-entry-into-owned.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,7 +149,8 @@ get-like calls.
never needs to manually implement. If there was support for `where A != B`
clauses we could get rid of the `RefIntoOwned` trait, but that would still
leave `IntoOwned` (which is strictly more general than the existing `ToOwned`
trait).
trait). On the other hand `IntoOwned` may be independently useful in generic
contexts.

2. It does not offer a way of recovering a `!Clone` key when no `insert`
happens. This is somewhat orthogonal though and could be solved in a number
Expand All @@ -160,6 +161,9 @@ get-like calls.
exact parameters of specialisation change, and this particular pattern
doesn't work anymore, we'll have painted ourselves into a corner.

4. The implementation would be insta-stable. There's no real way of
feature-gating this.

# Alternatives
[alternatives]: #alternatives

Expand Down