Fix "Replace match with if let" not to trigger when invalid transformations occur #20543
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #11373
closes: #19443
example:
before this PR
else clause never be executed (all val matches if clause)
this PR
"Replace match with if let" not shown up.
An alternative proposal and my thoughts of it
Switching the order of "if" and "else" in the above example and replacing "v" with "val" could work like below.
However, this idea requires more code, and it seems like over-engineering to me.