Skip to content

Conversation

bradfier
Copy link
Contributor

Version bump, primarily to get #832 and #892 in now that 1.19 is out and untagged unions are usable in stable!

r? @emilio

@highfive
Copy link

Thanks for the pull request, and welcome! The Servo team is excited to review your changes, and you should hear from @emilio (or someone else) soon.

@photoszzt
Copy link
Contributor

From the test output, the stable rust side is still emitting BindgenUnion(https://github.com/rust-lang-nursery/rust-bindgen/blob/master/tests/expectations/tests/anon_struct_in_union_1_0.rs)

@emilio
Copy link
Contributor

emilio commented Aug 27, 2017

Those are testing Rust 1.0 output.

Anyway, doing a new release sounds fine to me, @fitzgen, any reason we shouldn't?

@fitzgen
Copy link
Member

fitzgen commented Aug 28, 2017

Did stylo folks end up making their own bug-fix-only branch yet?

I see no reason not to release a 0.30.0 crate.

@emilio
Copy link
Contributor

emilio commented Aug 28, 2017

@bors-servo r+

  • Didn't, but no reason we can't in the future if we need to. shrug

@bors-servo
Copy link

📌 Commit 3cbdb98 has been approved by emilio

bors-servo pushed a commit that referenced this pull request Aug 28, 2017
Bump version to 0.30.0

Version bump, primarily to get #832 and #892 in now that 1.19 is out and untagged unions are usable in stable!

r? @emilio
@bors-servo
Copy link

⌛ Testing commit 3cbdb98 with merge 05caa82...

@fitzgen
Copy link
Member

fitzgen commented Aug 28, 2017

@emilio I'll write release notes and publish to crates.io if you haven't already

@emilio
Copy link
Contributor

emilio commented Aug 28, 2017

I planned to do so when it merges, but feel free to :)

@fitzgen
Copy link
Member

fitzgen commented Aug 28, 2017

Both release notes and publishing, or just the latter?

@emilio
Copy link
Contributor

emilio commented Aug 28, 2017

Mostly publishing. If you could do relnotes that'd be awesome, because it's taking a bit and I'm about to head out.

@fitzgen
Copy link
Member

fitzgen commented Aug 28, 2017

Sure thing

@bors-servo
Copy link

☀️ Test successful - status-travis
Approved by: emilio
Pushing 05caa82 to master...

@bors-servo bors-servo merged commit 3cbdb98 into rust-lang:master Aug 28, 2017
@fitzgen
Copy link
Member

fitzgen commented Aug 28, 2017

0.30.0 is published

@fitzgen
Copy link
Member

fitzgen commented Aug 28, 2017

And release notes published on r/rust and u.r-l.o

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants