Skip to content

Typo in literal_representation.rs #4809

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 15, 2020
Merged

Typo in literal_representation.rs #4809

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5c31efd
Typo in literal_representation.rs
iankronquist Nov 13, 2019
b13f4e4
Update literal_representation.rs
iankronquist Nov 26, 2019
aef2662
Update literal_representation.rs
iankronquist Nov 26, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Typo in literal_representation.rs 
Octal numbers can't have 8 in them ;)
  • Loading branch information
@iankronquist
iankronquist authored Nov 13, 2019
commit 5c31efd429e361947b7c54252145261a141c284e
2 changes: 1 addition & 1 deletion clippy_lints/src/literal_representation.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ declare_clippy_lint! {
/// **Known problems:**
/// - Recommends a signed suffix, even though the number might be too big and an unsigned
/// suffix is required
/// - Does not match on `_128` since that is a valid grouping for decimal and octal numbers
/// - Does not match on `_128` since that is a valid grouping for decimal and hexadecimal numbers
Copy link
Member

@flip1995 flip1995 Nov 13, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
/// - Does not match on `_128` since that is a valid grouping for decimal and hexadecimal numbers
/// - Does not match on `_127` since that is a valid grouping for decimal and octal numbers

It's not a valid grouping for hex number though 😉

///
/// **Example:**
///
Expand Down