Skip to content

Use mem::take instead of mem::replace when applicable #4881

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Jan 4, 2020
Merged

Use mem::take instead of mem::replace when applicable #4881

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
8db319f
Use `mem::take` instead of `mem::replace` when applicable
krishna-veerareddy Dec 8, 2019
2a75241
Add test cases for replace with `Default::default()`
krishna-veerareddy Dec 8, 2019
26812f7
Prevent `mem_replace_with_default` lint within macros
krishna-veerareddy Dec 8, 2019
78b4dfc
Move `mem_replace_with_default` out of nursery
krishna-veerareddy Dec 19, 2019
aa66f76
Destructure `mem:replace` arguments
krishna-veerareddy Dec 22, 2019
c09e79e
Lint within internal macros without a suggestion
krishna-veerareddy Dec 24, 2019
a8413a3
Remove unnecessary import
krishna-veerareddy Dec 24, 2019
42e4595
Indicate anonymous lifetimes for types
krishna-veerareddy Dec 29, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Remove unnecessary import
  • Loading branch information
@krishna-veerareddy
krishna-veerareddy committed Dec 31, 2019
commit a8413a32b379788d9610a78f6a2352a26a0d02e7
2 changes: 0 additions & 2 deletions tests/ui/mem_replace_macro.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,6 @@
#[macro_use]
extern crate macro_rules;

use std::mem;

macro_rules! take {
($s:expr) => {
std::mem::replace($s, Default::default())
Expand Down
2 changes: 1 addition & 1 deletion tests/ui/mem_replace_macro.stderr
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
error: replacing a value of type `T` with `T::default()` is better expressed using `std::mem::take`
--> $DIR/mem_replace_macro.rs:11:9
--> $DIR/mem_replace_macro.rs:9:9
|
LL | std::mem::replace($s, Default::default())
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
Expand Down