Skip to content

New Lint: wildcard imports #5029

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Feb 21, 2020
Merged

New Lint: wildcard imports #5029

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
8a572a5
Add tests for wildcard_imports lint
flip1995 Jan 7, 2020
ba1d50c
Implement wildcard_imports lint
flip1995 Jan 7, 2020
4229dbc
Run update_lints
flip1995 Jan 7, 2020
3f5ed28
Let's do it the easy way
flip1995 Jan 9, 2020
06a6189
Move enum_glob_use lint into wildcard_imports pass
flip1995 Jan 14, 2020
f4f781d
Filter prelude glob imports
flip1995 Feb 9, 2020
b67764d
Add test for prelude import
flip1995 Feb 9, 2020
8472ecd
Fix fallout
flip1995 Feb 21, 2020
b562a51
Don't use use ty::TyKind::*
flip1995 Feb 21, 2020
4dd2252
Fix suggestion for weird formattings
flip1995 Feb 21, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Filter prelude glob imports
  • Loading branch information
@flip1995
flip1995 committed Feb 21, 2020
commit f4f781d5cfd7a572006a8721c7998d13c378647d
2 changes: 2 additions & 0 deletions clippy_lints/src/wildcard_imports.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,6 +76,8 @@ impl LateLintPass<'_, '_> for WildcardImports {
if_chain! {
if !in_macro(item.span);
if let ItemKind::Use(use_path, UseKind::Glob) = &item.kind;
// don't lint prelude glob imports
if !use_path.segments.iter().last().map_or(false, |ps| ps.ident.as_str() == "prelude");
let used_imports = cx.tcx.names_imported_by_glob_use(item.hir_id.owner_def_id());
if !used_imports.is_empty(); // Already handled by `unused_imports`
then {
Expand Down