Skip to content

Share root project target dir to reduce compile time #5114

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Share root project target dir to reduce compile time #5114

wants to merge 1 commit into from

Conversation

@tesuji
Copy link
Contributor

@tesuji tesuji commented Jan 31, 2020

changelog: none

@tesuji tesuji requested a review from phansch January 31, 2020 13:45
@tesuji
Copy link
Contributor Author

tesuji commented Jan 31, 2020

cc #5109 (comment)

@tesuji tesuji closed this Jan 31, 2020
@tesuji tesuji deleted the dev-target-dir branch January 31, 2020 15:22
@tesuji
Copy link
Contributor Author

tesuji commented Jan 31, 2020

Hmm, think about it more. This change doesn't respect the CARGO_TARGET_DIR env.

@flip1995
Copy link
Member

flip1995 commented Jan 31, 2020

I don't think it really matters, since the compile time of clippy_dev is relatively low anyways. In CI we already set the CARGO_TARGET_DIR var anyway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@phansch phansch Awaiting requested review from phansch

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@tesuji @flip1995