Skip to content

Suggest Option::map_or(_else) for if let Some { y } else { x } #5301

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 14 commits into from
Jul 6, 2020
Merged

Suggest Option::map_or(_else) for if let Some { y } else { x } #5301

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
bf48a2d
Lint for if let Some(x) = ... instead of Option::map_or
JarredAllen Mar 5, 2020
82f8d4d
Stop linting on macros and correctly use braces for constructs
JarredAllen Apr 25, 2020
b85796f
Properly parenthesize to avoid operator precedence errors
JarredAllen Apr 25, 2020
88c8afd
Handle ref, mut, &, and &mut on the option
JarredAllen May 10, 2020
f73b455
Refactoring
JarredAllen May 10, 2020
7c4de9d
Refactoring pt. 2
JarredAllen May 12, 2020
5e20475
Don't lint if contains a macro
JarredAllen May 31, 2020
5150277
Used clippy to clean itself
JarredAllen May 31, 2020
93f0f5d
Last few tweaks
JarredAllen Jun 12, 2020
ccb9998
Fix compile error from library change
JarredAllen Jun 25, 2020
6ce9812
Clean existing lint code to match new lint
JarredAllen Jun 25, 2020
6e2d55c
Update compile-test to follow new lint
JarredAllen Jun 27, 2020
1c32263
Formatted updates to lints
JarredAllen Jul 1, 2020
c8f700e
Fixed compile errors
JarredAllen Jul 4, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix compile error from library change
  • Loading branch information
@JarredAllen
JarredAllen committed Jul 3, 2020
commit ccb999851aaa4d3e9cd97110bd6523a6c3df46fd
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1491,6 +1491,7 @@ Released 2018-09-13
[`large_stack_arrays`]: https://rust-lang.github.io/rust-clippy/master/index.html#large_stack_arrays
[`len_without_is_empty`]: https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty
[`len_zero`]: https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[`let_and_return`]: https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return
[`let_underscore_lock`]: https://rust-lang.github.io/rust-clippy/master/index.html#let_underscore_lock
[`let_underscore_must_use`]: https://rust-lang.github.io/rust-clippy/master/index.html#let_underscore_must_use
[`let_unit_value`]: https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value
Expand Down
2 changes: 1 addition & 1 deletion clippy_lints/src/option_if_let_else.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@ declare_lint_pass!(OptionIfLetElse => [OPTION_IF_LET_ELSE]);

/// Returns true iff the given expression is the result of calling `Result::ok`
fn is_result_ok(cx: &LateContext<'_, '_>, expr: &'_ Expr<'_>) -> bool {
if let ExprKind::MethodCall(ref path, _, &[ref receiver]) = &expr.kind {
if let ExprKind::MethodCall(ref path, _, &[ref receiver], _) = &expr.kind {
path.ident.name.to_ident_string() == "ok" && match_type(cx, &cx.tables.expr_ty(&receiver), &paths::RESULT)
} else {
false
Expand Down