box_vec: dont use Box<&T> #5310
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flip1995
reviewed
Mar 12, 2020
flip1995
added
the
S-waiting-on-author
jpospychala
force-pushed
the
box_rptr
branch
3 times, most recently
from
b7edf08 to
ca5f1c0
Compare
flip1995
reviewed
Mar 14, 2020
jpospychala
force-pushed
the
box_rptr
branch
2 times, most recently
from
d7eea04 to
7196d14
Compare
flip1995
reviewed
Mar 18, 2020
jpospychala
force-pushed
the
box_rptr
branch
2 times, most recently
from
a35a8b2 to
f9d5758
Compare
Manishearth
approved these changes
Mar 30, 2020
| cx, | ||
| BOX_BORROWS, | ||
| hir_ty.span, | ||
| "usage of `Box<&T>`", |
Member
There was a problem hiding this comment.
We should use span_lint_and_suggestion here and emit a suggestion instead of a help
Member
There was a problem hiding this comment.
With the text being something like "Box<&T> does not offer any advantages over &T, please try: {}"
Member
There was a problem hiding this comment.
You'd want to also add a fixture test for this (add run-rustfix to the top and run/update the tests a couple times)
Contributor
|
☔ The latest upstream changes (presumably #5294) made this pull request unmergeable. Please resolve the merge conflicts. |
Contributor
Author
|
moving those changes to #5349 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refers to #2394
Don't use Box<&T>