Skip to content

If let else mutex #5332

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 16 commits into from
Apr 20, 2020
Merged

If let else mutex #5332

Changes from 1 commit
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
001a42e
progress work on suggestion for auto fix
DevinR528 Mar 5, 2020
139e2c6
creating suggestion
DevinR528 Mar 5, 2020
40bbdff
use span_lint_and_help, cargo dev fmt
DevinR528 Mar 18, 2020
51c2325
move closures to seperate fns, remove known problems
DevinR528 Mar 18, 2020
fca3537
add note about update-all-refs script, revert redundant pat to master
DevinR528 Mar 18, 2020
c6c77d9
use Visitor api to find Mutex::lock calls
DevinR528 Mar 18, 2020
930619b
change visitor name to OppVisitor
DevinR528 Mar 18, 2020
1ee04e4
fix internal clippy warnings
DevinR528 Mar 18, 2020
2e8a2de
dev update_lints
DevinR528 Mar 24, 2020
7242fa5
fix map import to rustc_middle
DevinR528 Mar 30, 2020
4cebe2b
cargo dev fmt
DevinR528 Mar 30, 2020
ae82092
use if chain
DevinR528 Apr 15, 2020
a9f1bb4
test for mutex eq, add another test case
DevinR528 Apr 15, 2020
d1b1a4c
update span_lint_and_help call to six args
DevinR528 Apr 20, 2020
489dd2e
factor ifs into function, add differing mutex test
DevinR528 Apr 20, 2020
3fbe321
update stderr file
DevinR528 Apr 20, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
change visitor name to OppVisitor
  • Loading branch information
@DevinR528
DevinR528 committed Apr 20, 2020
commit 930619b484893f52c22e6e3fce22422501d4e326
6 changes: 3 additions & 3 deletions clippy_lints/src/if_let_mutex.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ impl LateLintPass<'_, '_> for IfLetMutex {
arm_lock: false,
cx,
};
let mut op_visit = IfLetMutexVisitor {
let mut op_visit = OppVisitor {
op_mutex: false,
op_lock: false,
cx,
Expand Down Expand Up @@ -80,13 +80,13 @@ impl LateLintPass<'_, '_> for IfLetMutex {
}

/// Checks if `Mutex::lock` is called in the `if let _ = expr.
pub struct IfLetMutexVisitor<'tcx, 'l> {
pub struct OppVisitor<'tcx, 'l> {
pub op_mutex: bool,
pub op_lock: bool,
pub cx: &'tcx LateContext<'tcx, 'l>,
}

impl<'tcx, 'l> Visitor<'tcx> for IfLetMutexVisitor<'tcx, 'l> {
impl<'tcx, 'l> Visitor<'tcx> for OppVisitor<'tcx, 'l> {
type Map = Map<'tcx>;

fn visit_expr(&mut self, expr: &'tcx Expr<'_>) {
Expand Down