Skip to content

Issue4983 bool updates #5365

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 30, 2020
Merged

Issue4983 bool updates #5365

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
12796cd
Initial lint without suggestion
mgr-inz-rafal Mar 23, 2020
3d3af07
Provide appropriate suggestion
mgr-inz-rafal Mar 23, 2020
ff96025
Code clean-up and formatting
mgr-inz-rafal Mar 23, 2020
c8f3241
Update clippy_lints/src/needless_bool.rs
yaahc Mar 30, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Update clippy_lints/src/needless_bool.rs
  • Loading branch information
@yaahc
yaahc authored Mar 30, 2020
commit c8f32411777f8287cccb8fa9ab69df17496831af
2 changes: 1 addition & 1 deletion clippy_lints/src/needless_bool.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -212,7 +212,7 @@ fn one_side_is_unary_not<'tcx>(left_side: &'tcx Expr<'_>, right_side: &'tcx Expr
let right = is_unary_not(right_side);

ExpressionInfoWithSpan {
one_side_is_unary_not: left.0 ^ right.0,
one_side_is_unary_not: left.0 != right.0,
left_span: left.1,
right_span: right.1,
}
Expand Down