Skip to content

Conversation

@yoav-lavi
Copy link
Contributor

[pub_use]

Fixes #8545

  • Followed lint naming conventions
  • Added passing UI tests (including committed .stderr file)
  • cargo test passes locally
  • Executed cargo dev update_lints
  • Added lint documentation
  • Run cargo dev fmt

changelog: Adds a lint called pub_use that restricts the usage of pub use ...

@rust-highfive
Copy link

r? @giraffate

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Apr 9, 2022
@yoav-lavi
Copy link
Contributor Author

Adding the lint docs

@bors
Copy link
Contributor

bors commented Apr 11, 2022

☔ The latest upstream changes (presumably #8660) made this pull request unmergeable. Please resolve the merge conflicts.

@giraffate
Copy link
Contributor

Can you do a rebase, not merge commit? We follow a no-merge commit policy: https://github.com/rust-lang/rust-clippy/blob/master/doc/basics.md#pr

@yoav-lavi
Copy link
Contributor Author

yoav-lavi commented Apr 12, 2022

Sure, no problem, will rebase. Are there any changes that should be made to the contents?

@giraffate
Copy link
Contributor

Oh, I haven't been able to review it yet. Sorry, please wait a little longer.

@yoav-lavi
Copy link
Contributor Author

No worries, was trying to understand if we're pre or post review, whenever you can is ok 🙂

@yoav-lavi
Copy link
Contributor Author

Done @giraffate

@yoav-lavi
Copy link
Contributor Author

The rebase removed the description, will be able to fix later

@yoav-lavi yoav-lavi closed this Apr 12, 2022
@yoav-lavi yoav-lavi deleted the main branch April 12, 2022 12:26
@yoav-lavi yoav-lavi restored the main branch April 12, 2022 12:27
@yoav-lavi yoav-lavi reopened this Apr 12, 2022
@yoav-lavi yoav-lavi requested a review from giraffate April 13, 2022 11:51
@giraffate
Copy link
Contributor

@bors r+

Thanks!

@bors
Copy link
Contributor

bors commented Apr 13, 2022

📌 Commit 66d253f has been approved by giraffate

@bors
Copy link
Contributor

bors commented Apr 13, 2022

⌛ Testing commit 66d253f with merge b6645d0...

@bors
Copy link
Contributor

bors commented Apr 13, 2022

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: giraffate
Pushing b6645d0 to master...

@bors bors merged commit b6645d0 into rust-lang:master Apr 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-review Status: Awaiting review from the assignee but also interested parties

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Detect pub use statements

4 participants