Skip to content

Fix argument splitting in compiletest #132599

@jieyouxu

Description

@jieyouxu

We should fix how arguments are split in compiletest, this involves multiple places:

  • The custom diff tool
  • //@ compile-flags and such

They usually involve converting from a user-provided escaped string to Command::new() and Command::arg and such, but yeah. Command arg splitting in compiletest is currently very naive and usually just splits on whitespace or is otherwise very basic, we should probably just use a proper library to handle the splitting...

Metadata

Metadata

Assignees

No one assigned

    Labels

    A-compiletestArea: The compiletest test runnerC-bugCategory: This is a bug.E-mediumCall for participation: Medium difficulty. Experience needed to fix: Intermediate.T-bootstrapRelevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)

    Type

    Projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions