Skip to content

Don't build compiler_builtins with -C panic=abort #103786

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bors merged 2 commits into from
Nov 27, 2022
Merged

Don't build compiler_builtins with -C panic=abort #103786

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c6ea362
remove obsolete comment
tshepang Oct 31, 2022
b21674f
remove unused code
tshepang Nov 25, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
remove obsolete comment
  • Loading branch information
@tshepang
tshepang committed Nov 25, 2022
commit c6ea362571bd7f7bc0d36b2aa61b44e183a2d841
4 changes: 0 additions & 4 deletions src/bootstrap/bin/rustc.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,10 +97,6 @@ fn main() {
// This... is a bit of a hack how we detect this. Ideally this
// information should be encoded in the crate I guess? Would likely
// require an RFC amendment to RFC 1513, however.
//
// `compiler_builtins` are unconditionally compiled with panic=abort to
// workaround undefined references to `rust_eh_unwind_resume` generated
// otherwise, see issue https://github.com/rust-lang/rust/issues/43095.
if crate_name == Some("panic_abort")
|| crate_name == Some("compiler_builtins") && stage != "0"
{
Expand Down