Skip to content

Strengthen state tracking in const-prop #108872

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bors merged 13 commits into from
Mar 13, 2023
Merged

Strengthen state tracking in const-prop #108872

Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
9a56933
Create visit_block_data for const-prop-lint.
cjgillot Mar 7, 2023
2247cd6
Simplify visit_statement.
cjgillot Mar 7, 2023
0e64ce7
Do not track span in ConstProp.
cjgillot Mar 5, 2023
081bc75
Assume the frame has all the locals.
cjgillot Mar 7, 2023
24dbf9c
Only assign value in remove_const.
cjgillot Mar 7, 2023
9928d0e
Remove OnlyPropagateInto.
cjgillot Mar 7, 2023
d97a7ce
Refactor tracking of writes.
cjgillot Mar 7, 2023
f00be8b
Recurse into statement before applying its effect.
cjgillot Mar 7, 2023
b55c4f8
Separate checking rvalue from evaluation.
cjgillot Mar 7, 2023
0d56034
Make comment more explicit.
cjgillot Mar 7, 2023
a5a01b2
Fortify clippy tests.
cjgillot Mar 7, 2023
d94ec30
Bless 32bit.
cjgillot Mar 8, 2023
8179b2e
Remove useless parameter to operand_from_scalar.
cjgillot Mar 8, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Bless 32bit.
  • Loading branch information
@cjgillot
cjgillot committed Mar 8, 2023
commit d94ec3091ecc663ef30f288ac859694e2512f31b
2 changes: 1 addition & 1 deletion tests/mir-opt/const_prop/discriminant.main.ConstProp.32bit.diff
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@
- switchInt(move _4) -> [1: bb1, otherwise: bb3]; // scope 2 at $DIR/discriminant.rs:+1:21: +1:31
+ _3 = const Option::<bool>::Some(true); // scope 2 at $DIR/discriminant.rs:+1:34: +1:44
+ // mir::Constant
+ // + span: $DIR/discriminant.rs:12:34: 12:44
+ // + span: no-location
+ // + literal: Const { ty: Option<bool>, val: Value(Scalar(0x01)) }
+ _4 = const 1_isize; // scope 2 at $DIR/discriminant.rs:+1:21: +1:31
+ switchInt(const 1_isize) -> [1: bb1, otherwise: bb3]; // scope 2 at $DIR/discriminant.rs:+1:21: +1:31
Expand Down