Comments

compiler/rustc_lint/messages.ftl

@@ -192,7 +192,7 @@ lint_redundant_semicolons =
         *[false] this semicolon
     }
 
-lint_useless_send_constraint = constraining a reference to `Send` is meaningless
+lint_unnecessary_send_constraint = constraining a reference to `Send` is meaningless
     .suggestion = {$only_trait ->
         [true] replace this with `std::any::Any`
         *[false] remove this

compiler/rustc_lint/src/lib.rs

@@ -77,7 +77,7 @@ mod redundant_semicolon;
 mod traits;
 mod types;
 mod unused;
-mod useless_send_constraint;
+mod unnecessary_send_constraint;
 
 pub use array_into_iter::ARRAY_INTO_ITER;
 
@@ -126,7 +126,7 @@ pub use passes::{EarlyLintPass, LateLintPass};
 pub use rustc_session::lint::Level::{self, *};
 pub use rustc_session::lint::{BufferedEarlyLint, FutureIncompatibleInfo, Lint, LintId};
 pub use rustc_session::lint::{LintArray, LintPass};
-use useless_send_constraint::UselessSendConstraint;
+use unnecessary_send_constraint::UselessSendConstraint;
 
 fluent_messages! { "../messages.ftl" }
 

compiler/rustc_lint/src/useless_send_constraint.rs → compiler/rustc_lint/src/unnecessary_send_constraint.rs

@@ -2,10 +2,10 @@ use rustc_span::sym;
 
 use crate::hir;
 
-use crate::{lints::UselessSendConstraintDiag, LateContext, LateLintPass};
+use crate::{lints::UnnecessarySendConstraintDiag, LateContext, LateLintPass};
 
 declare_lint! {
-    /// The `lint_useless_send_constraint` lints useless constraint of references to `Send`.
+    /// The `lint_unnecessary_send_constraint` lints unnecessary constraint of references to `Send`.
     ///
     /// ### Example
     ///
@@ -17,15 +17,15 @@ declare_lint! {
     ///
     /// ### Explanation
     ///
-    /// References cannot be sent across threads unless they have a `Sync` bound, so constraining them to `Send` without `Sync` is useless.
-    pub USELESS_SEND_CONSTRAINT,
+    /// References cannot be sent across threads unless they have a `Sync` bound, so constraining them to `Send` without `Sync` is unnecessary.
+    pub UNNECESSARY_SEND_CONSTRAINT,
     Warn,
-    "constraining a reference to `Send` without `Sync` is useless, consider removing it"
+    "constraining a reference to `Send` without `Sync` is unnecessary, consider removing it"
 }
 
-declare_lint_pass!(UselessSendConstraint => [USELESS_SEND_CONSTRAINT]);
+declare_lint_pass!(UnnecessarySendConstraint => [UNNECESSARY_SEND_CONSTRAINT]);
 
-impl<'tcx> LateLintPass<'tcx> for UselessSendConstraint {
+impl<'tcx> LateLintPass<'tcx> for UnnecessarySendConstraint {
     fn check_ty(&mut self, cx: &LateContext<'tcx>, ty: &'tcx hir::Ty<'tcx>) {
         let hir::TyKind::Ref(
             ..,
@@ -46,10 +46,10 @@ impl<'tcx> LateLintPass<'tcx> for UselessSendConstraint {
             let only_trait = bounds.len() == 1;
 
             cx.tcx.emit_spanned_lint(
-                USELESS_SEND_CONSTRAINT,
+                UNNECESSARY_SEND_CONSTRAINT,
                 send_bound.trait_ref.hir_ref_id, // is this correct?
                 send_bound.span,
-                UselessSendConstraintDiag { only_trait, suggestion: send_bound.span },
+                UnnecessarySendConstraintDiag { only_trait, suggestion: send_bound.span },
             )
         }
     }