Skip to content

Remove a now-unnecessary check for generators. #115763

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
oli-obk wants to merge 3 commits into from
Closed

Remove a now-unnecessary check for generators. #115763

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
aad707d
Ignore ICE dumps
oli-obk Sep 11, 2023
9597d24
Fix rustfmt path in default vscode settings.json
oli-obk Sep 11, 2023
07782ed
Remove a now-unnecessary check for generators.
oli-obk Sep 11, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix rustfmt path in default vscode settings.json 
The r-a vscode extension has started `cd`-ing into the current crate's root directory, and then invoking rustfmt. But our rustfmt path is relative, and was then not available.
  • Loading branch information
@oli-obk
oli-obk committed Sep 11, 2023
commit 9597d24f859421fce8067d6e1f18998156bb3da4
2 changes: 1 addition & 1 deletion src/etc/rust_analyzer_settings.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
"compiler/rustc_codegen_gcc/Cargo.toml"
],
"rust-analyzer.rustfmt.overrideCommand": [
"./build/host/rustfmt/bin/rustfmt",
"${workspaceFolder}/build/host/rustfmt/bin/rustfmt",
"--edition=2021"
],
"rust-analyzer.procMacro.server": "./build/host/stage0/libexec/rust-analyzer-proc-macro-srv",
Expand Down