Skip to content

Minor improvements to rustc_ast_passes #117204

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bors merged 7 commits into from
Nov 2, 2023
Merged

Minor improvements to rustc_ast_passes #117204

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
bb3e09f
Streamline `gate_feature_*` macros.
nnethercote Oct 26, 2023
531b38a
Cover two more cases in the `gate_doc` macro.
nnethercote Oct 26, 2023
dcb72e7
Use a slice pattern to neaten a condition.
nnethercote Oct 26, 2023
c88954e
Use `if let` to reduce some excessive indentation.
nnethercote Oct 26, 2023
de17ec9
Rearrange the `gate_feature_*` macros.
nnethercote Oct 29, 2023
499b309
Fix a `FIXME`, by adding a `gate_multi` macro.
nnethercote Oct 29, 2023
5b391b0
Test the multispan case in `tests.ui/bounds-lifetime.rs`.
nnethercote Oct 29, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Use a slice pattern to neaten a condition.
  • Loading branch information
@nnethercote
nnethercote committed Oct 30, 2023
commit dcb72e705fccc17ca4f865708e6ba69dc680c71f
11 changes: 3 additions & 8 deletions compiler/rustc_ast_passes/src/feature_gate.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -199,17 +199,12 @@ impl<'a> Visitor<'a> for PostExpansionVisitor<'a> {
}
}
if !attr.is_doc_comment()
&& attr.get_normal_item().path.segments.len() == 2
&& attr.get_normal_item().path.segments[0].ident.name == sym::diagnostic
&& let [seg, _] = attr.get_normal_item().path.segments.as_slice()
&& seg.ident.name == sym::diagnostic
&& !self.features.diagnostic_namespace
{
let msg = "`#[diagnostic]` attribute name space is experimental";
gate_feature_post!(
self,
diagnostic_namespace,
attr.get_normal_item().path.segments[0].ident.span,
msg
);
gate_feature_post!(self, diagnostic_namespace, seg.ident.span, msg);
}

// Emit errors for non-staged-api crates.
Expand Down