Skip to content

Rollup of 4 pull requests #117482

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bors merged 8 commits into from
Nov 1, 2023
Merged

Rollup of 4 pull requests #117482

Changes from 2 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
91405ab
Clean up unchecked_math, separate out unchecked_shifts
clarfonthey Sep 7, 2023
8076414
Don't emit delayed good-path bugs on panic
compiler-errors Oct 30, 2023
147c4a5
Refactor: move suggestion functions from demand to suggestions
chenyukang Oct 30, 2023
587af91
Inline and remove `create_session`.
nnethercote Oct 30, 2023
260e07b
Rollup merge of #115626 - clarfonthey:unchecked-math, r=thomcc
matthiaskrgr Nov 1, 2023
6bbe22c
Rollup merge of #117397 - compiler-errors:dont-emit-good-path-on-pani…
matthiaskrgr Nov 1, 2023
6c893e6
Rollup merge of #117401 - chenyukang:yukang-cleanup-hir-typeck-sugges…
matthiaskrgr Nov 1, 2023
515fdbf
Rollup merge of #117475 - nnethercote:rm-create_session, r=oli-obk
matthiaskrgr Nov 1, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion compiler/rustc_errors/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -556,7 +556,7 @@ impl Drop for HandlerInner {
// instead of "require some error happened". Sadly that isn't ideal, as
// lints can be `#[allow]`'d, potentially leading to this triggering.
// Also, "good path" should be replaced with a better naming.
if !self.has_any_message() && !self.suppressed_expected_diag {
if !self.has_any_message() && !self.suppressed_expected_diag && !std::thread::panicking() {
let bugs = std::mem::replace(&mut self.delayed_good_path_bugs, Vec::new());
self.flush_delayed(
bugs,
Expand Down