Skip to content

improve codegen of fmt_num to delete unreachable panic #122770

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bors merged 3 commits into from
Nov 14, 2024
Merged

improve codegen of fmt_num to delete unreachable panic #122770

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e7fbf72
improve codegen of fmt_num to delete unreachable panic
iximeow Mar 20, 2024
cea973f
try adding a test that LowerHex and friends don't panic, but it doesn…
iximeow Mar 23, 2024
a54d6ad
Delete tests/codegen/fmt_int_no_panic.rs
iximeow Nov 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Delete tests/codegen/fmt_int_no_panic.rs 
this test was included for demonstrative and discussion purposes but does not test what its name alleges - in fact it does not test much of value at all!

as mentioned in this comment, #122770 (comment) , writing a correct test for this codegen outcome is difficult (partially because the public interface to std::fmt intentionally includes an #[inline(never)] function!), so to test this correctly will require more than i can offer in 122770.
  • Loading branch information
@iximeow
iximeow authored Nov 13, 2024
commit a54d6ad03945d071ad74cb0363c12fd613fd9430
24 changes: 0 additions & 24 deletions tests/codegen/fmt_int_no_panic.rs
View file
Open in desktop

This file was deleted.

Loading