Skip to content

refactor clippy in bootstrap #122883

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bors merged 8 commits into from
Apr 17, 2024
Merged

refactor clippy in bootstrap #122883

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
81b7944
create new build step `clippy`
onur-ozkan Mar 22, 2024
8a865a0
create `Builder::msg_clippy`
onur-ozkan Mar 22, 2024
77ba3f2
support different `Kind`s in `Builder::msg_tool`
onur-ozkan Mar 22, 2024
489e5d0
for clippy, skip output handling in `run_cargo`
onur-ozkan Mar 22, 2024
bbacfe0
add simple top-level doc-comment for build_steps/clippy
onur-ozkan Mar 22, 2024
a018973
fix sysroot bug and update step message format
onur-ozkan Mar 22, 2024
5253fe4
update `mingw-check` clippy invocation
onur-ozkan Mar 22, 2024
16cf0e6
allow running clippy on most of the in-tree tools
onur-ozkan Mar 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
update mingw-check clippy invocation 
Previously this command was linting compiler and library together.
As we no longer run clippy on the entire tree unless it's explicitly
requested, we need to update this command by adding `library` path.

Signed-off-by: onur-ozkan <[email protected]>
  • Loading branch information
@onur-ozkan
onur-ozkan committed Apr 16, 2024
commit 5253fe4520dc14934f9cd99859da42a18686550f
2 changes: 1 addition & 1 deletion src/ci/docker/host-x86_64/mingw-check/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ ENV SCRIPT python3 ../x.py --stage 2 test src/tools/expand-yaml-anchors && \
# We also skip the x86_64-unknown-linux-gnu target as it is well-tested by other jobs.
python3 ../x.py check --stage 0 --set build.optimized-compiler-builtins=false core alloc std --target=aarch64-unknown-linux-gnu,i686-pc-windows-msvc,i686-unknown-linux-gnu,x86_64-apple-darwin,x86_64-pc-windows-gnu,x86_64-pc-windows-msvc && \
python3 ../x.py check --target=i686-pc-windows-gnu --host=i686-pc-windows-gnu && \
python3 ../x.py clippy compiler -Aclippy::all -Dclippy::correctness && \
python3 ../x.py clippy compiler library -Aclippy::all -Dclippy::correctness && \
python3 ../x.py build --stage 0 src/tools/build-manifest && \
python3 ../x.py test --stage 0 src/tools/compiletest && \
python3 ../x.py test --stage 0 core alloc std test proc_macro && \
Expand Down