Skip to content

[beta] backports #124947

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bors merged 2 commits into from
May 10, 2024
Merged

[beta] backports #124947

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4b8149f
Consider inner modules to be local in the `non_local_definitions` lint
Urgau Apr 26, 2024
6c68ae6
Fix bootstrap panic when build from tarball
12101111 May 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Fix bootstrap panic when build from tarball 
(cherry picked from commit f13edeb)
  • Loading branch information
@12101111 @cuviper
12101111 authored and cuviper committed May 9, 2024
commit 6c68ae64dfe66e9e495a64f6f3b19cd48c92a7ad
7 changes: 1 addition & 6 deletions src/bootstrap/src/core/builder.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2226,13 +2226,8 @@ impl<'a> Builder<'a> {
out
}

/// Return paths of all submodules managed by git.
/// If the current checkout is not managed by git, returns an empty slice.
/// Return paths of all submodules.
pub fn get_all_submodules(&self) -> &[String] {
if !self.rust_info().is_managed_git_subrepository() {
return &[];
}

static SUBMODULES_PATHS: OnceLock<Vec<String>> = OnceLock::new();

let init_submodules_paths = |src: &PathBuf| {
Expand Down