-
Notifications
You must be signed in to change notification settings - Fork 14.1k
Rewrite extern-flag-rename-transitive. debugger-visualizer-dep-info, metadata-flag-frobs-symbols, extern-overrides-distribution and forced-unwind-terminate-pof run-make tests to rmake
#126644
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
060a13e
rewrite extern-flag-rename-transitive to rmake
Oneirical 9e2ace8
rewrite debugger-visualizer-dep-info to rmake
Oneirical dff354e
rewrite metadata-flag-frobs-symbols to rmake
Oneirical d1e8c6b
rewrite extern-overrides-distribution to rmake
Oneirical e7ea063
rewrite forced-unwind-terminate-pof to rmake
Oneirical File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
rewrite metadata-flag-frobs-symbols to rmake
- Loading branch information
commit dff354e57fe030f8fa0467f092b75e8979a3cce9
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,21 @@ | ||
| // In this test, foo.rs is compiled twice with different hashes tied to its | ||
| // symbols thanks to the metadata flag. bar.rs then ensures that the memory locations | ||
| // of foo's symbols are different even though they came from the same original source code. | ||
| // This checks that the metadata flag is doing its job. | ||
| // See https://github.com/rust-lang/rust/issues/14471 | ||
|
|
||
| //@ ignore-cross-compile | ||
|
|
||
| use run_make_support::{run, rust_lib_name, rustc}; | ||
|
|
||
| fn main() { | ||
| rustc().input("foo.rs").metadata("a").extra_filename("-a").run(); | ||
| rustc().input("foo.rs").metadata("b").extra_filename("-b").run(); | ||
| rustc() | ||
| .input("bar.rs") | ||
| .extern_("foo1", rust_lib_name("foo-a")) | ||
| .extern_("foo2", rust_lib_name("foo-b")) | ||
| .print("link-args") | ||
| .run(); | ||
| run("bar"); | ||
| } | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Question: is this supposed to be checking output of
--print=link-args? I know the original test does the same thing.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You mean, if it should be
run_unchecked? I don't see why, if the original test worked on all platforms asrun, why would we need to reduce the exactitude of the test by not checking?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No I mean that this invocation uses
--print=link-argsbut we're not checking what stdout contains (or what the content of--print=link-argsis), is that intentional?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That is quite weird indeed, my guess is that the test writer left it in as a way to debug their own test if it failed. The test works locally without it, so I am removing it now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, r=me when CI passes