Skip to content
Closed
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
25 commits
Select commit Hold shift + click to select a range
f22775b
ignore `llvm::Lld` step if `lld` is not enabled
onur-ozkan Jun 19, 2024
c890a81
add `lld = true` to default dist profile
onur-ozkan Jun 19, 2024
bfca652
disable lld if external llvm is used
onur-ozkan Jun 19, 2024
11acf83
bootstrap: exclude cargo from package metadata
onur-ozkan Jun 14, 2024
457ac5d
don't fetch/sync cargo submodule by default
onur-ozkan Jun 14, 2024
8c3ebf7
refactor `tool_doc` macro in bootstrap
onur-ozkan Jun 14, 2024
51f6e68
handle cargo submodule in a lazy-load way
onur-ozkan Jun 14, 2024
ac7595f
Support for -Z patchable-function-entry
maurer Dec 12, 2023
9b0ae75
Support `#[patchable_function_entries]`
maurer Dec 12, 2023
7c56398
Updated code for changes to RFC, added additional error handling, added
nebulark May 2, 2024
d5ff4f4
Simplify `str::clone_into`
DaniPopes Jun 25, 2024
2c9556d
fix UI test, simplify error message
joboet Jun 25, 2024
23d1cc4
core: avoid `extern` types in formatting infrastructure
joboet Jun 25, 2024
7526416
update coverage test
joboet Jun 25, 2024
7e7d0a9
core: improve comment
joboet Jun 27, 2024
3457ecc
remove unnecessary packages from `metadata::workspace_members`
onur-ozkan Jun 27, 2024
b1b473e
add change-tracker entry
onur-ozkan Jun 27, 2024
789ee88
Tighten spans for async blocks
compiler-errors Jun 27, 2024
8d246b0
Updated diagnostic messages
nebulark Jun 26, 2024
75834c9
Rollup merge of #124741 - nebulark:patchable-function-entries-pr, r=e…
matthiaskrgr Jun 28, 2024
6909cde
Rollup merge of #126470 - onur-ozkan:optional-cargo-submodule, r=Kobzol
matthiaskrgr Jun 28, 2024
71f9d3a
Rollup merge of #126701 - onur-ozkan:build-lld-if-enabled, r=Kobzol
matthiaskrgr Jun 28, 2024
e94100b
Rollup merge of #126956 - joboet:fmt_no_extern_ty, r=RalfJung
matthiaskrgr Jun 28, 2024
a66f2c2
Rollup merge of #126970 - DaniPopes:simplify-str-clone_into, r=cuviper
matthiaskrgr Jun 28, 2024
f305466
Rollup merge of #127058 - compiler-errors:tighten-async-spans, r=oli-obk
matthiaskrgr Jun 28, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
handle cargo submodule in a lazy-load way
Signed-off-by: onur-ozkan <[email protected]>
  • Loading branch information
onur-ozkan committed Jun 24, 2024
commit 51f6e68559bdef1a1b16b3d026552eab51b5f389
3 changes: 3 additions & 0 deletions src/bootstrap/src/core/build_steps/test.rs
Original file line number Diff line number Diff line change
Expand Up @@ -2983,6 +2983,9 @@ impl Step for Bootstrap {
let compiler = builder.compiler(0, host);
let _guard = builder.msg(Kind::Test, 0, "bootstrap", host, host);

// Some tests require cargo submodule to be present.
builder.build.update_submodule(Path::new("src/tools/cargo"));

let mut check_bootstrap = Command::new(builder.python());
check_bootstrap
.args(["-m", "unittest", "bootstrap_test.py"])
Expand Down
2 changes: 2 additions & 0 deletions src/bootstrap/src/core/build_steps/tool.rs
Original file line number Diff line number Diff line change
Expand Up @@ -654,6 +654,8 @@ impl Step for Cargo {
}

fn run(self, builder: &Builder<'_>) -> PathBuf {
builder.build.update_submodule(Path::new("src/tools/cargo"));

builder.ensure(ToolBuild {
compiler: self.compiler,
target: self.target,
Expand Down
5 changes: 4 additions & 1 deletion src/bootstrap/src/core/build_steps/vendor.rs
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
use crate::core::builder::{Builder, RunConfig, ShouldRun, Step};
use std::path::PathBuf;
use std::path::{Path, PathBuf};
use std::process::Command;

#[derive(Debug, Clone, Hash, PartialEq, Eq)]
Expand Down Expand Up @@ -34,6 +34,9 @@ impl Step for Vendor {
cmd.arg("--versioned-dirs");
}

// cargo submodule must be present for `x vendor` to work.
builder.build.update_submodule(Path::new("src/tools/cargo"));

// Sync these paths by default.
for p in [
"src/tools/cargo/Cargo.toml",
Expand Down