Skip to content
Merged
Changes from 1 commit
Commits
Show all changes
30 commits
Select commit Hold shift + click to select a range
36b1f44
Add a test for `*const Tr<A>` to `*const Tr<B>` casts
WaffleLapkin Jan 22, 2024
d06cf5b
Forbid casts of raw pointers to trait objects with the same trait, bu…
WaffleLapkin Jan 22, 2024
9e8ef92
Add tests for `*const Trait<'a>` -> `*const Trait<'b>` and similar casts
WaffleLapkin Jan 22, 2024
5645e8e
Add more checks for pointers with vtable meta
WaffleLapkin Feb 12, 2024
bb651d3
blessings
WaffleLapkin Feb 13, 2024
eac4916
Disallow `dyn Trait -> dyn Auto` back
WaffleLapkin Jun 4, 2024
e85295c
test blessing
WaffleLapkin Jun 4, 2024
c743557
Actually check that the traits are the same for casting pointers to d…
WaffleLapkin Jun 4, 2024
340d69b
Align the changes to the lang decision
WaffleLapkin Jun 23, 2024
06863ee
Delete `CloneAny` from `rust-analyzer`'s fork of `AnyMap`
WaffleLapkin Jun 23, 2024
cf7032f
Small fixes from review
WaffleLapkin Jun 23, 2024
b16f803
Make `DiagSymbolList` more generic
WaffleLapkin Jul 4, 2024
dc420a2
Use `DiagSymbolList` for a lint diagnostic
WaffleLapkin Jul 4, 2024
52ba120
Remove unhelpful comments and add helpful ones
WaffleLapkin Jul 4, 2024
9ef533e
Fill in tracking issue
WaffleLapkin Jul 4, 2024
a1f20f1
Properly normalize types in bck when checking pointer casts
WaffleLapkin Jul 4, 2024
56de9da
Sort trait names before printing
WaffleLapkin Jul 4, 2024
073f3a2
Equate types instead of using `Unsize`
WaffleLapkin Jul 5, 2024
6aebb2c
Add test.
cjgillot Jul 5, 2024
b97f83b
Verify that allocations output by GVN are sufficiently aligned.
cjgillot Jul 5, 2024
12edc8d
Update compiler/rustc_mir_transform/src/gvn.rs
cjgillot Jul 6, 2024
3e9c9a0
Mark format! with must_use hint
Jul 4, 2024
a0f2b41
clarify `sys::unix::fd::FileDesc::drop` comment (#66876)
tnuha Jul 7, 2024
f3c13bf
Allow casting `*mut dyn T`->`*mut (dyn T + Send)` if `T` has `Send` s…
WaffleLapkin Jul 7, 2024
8076a33
bootstrap: once_cell::sync::Lazy -> std::sync::LazyLock
GrigorenkoPV Jul 7, 2024
c4ee2df
Rollup merge of #120248 - WaffleLapkin:bonk-ptr-object-casts, r=compi…
matthiaskrgr Jul 8, 2024
5b6eb28
Rollup merge of #127355 - aceArt-GmbH:126475, r=oli-obk
matthiaskrgr Jul 8, 2024
3e8e8df
Rollup merge of #127399 - cjgillot:issue-127396, r=oli-obk
matthiaskrgr Jul 8, 2024
55d25ce
Rollup merge of #127460 - Borgerr:clarify-drop-comment, r=jhpratt
matthiaskrgr Jul 8, 2024
a659f7a
Rollup merge of #127467 - GrigorenkoPV:bootstrap-once_cell, r=clubby789
matthiaskrgr Jul 8, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
clarify sys::unix::fd::FileDesc::drop comment (#66876)
  • Loading branch information
tnuha committed Jul 7, 2024
commit a0f2b41d03bd5118df86f29d5a75756990bc4cd9
5 changes: 5 additions & 0 deletions library/std/src/os/fd/owned.rs
Original file line number Diff line number Diff line change
Expand Up @@ -175,6 +175,11 @@ impl Drop for OwnedFd {
// the file descriptor was closed or not, and if we retried (for
// something like EINTR), we might close another valid file descriptor
// opened after we closed ours.
// However, this is usually justified, as some of the major Unices
// do make sure to always close the FD, even when `close()` is interrupted,
// and the scenario is rare to begin with.
// Helpful link to an epic discussion by POSIX workgroup:
// http://austingroupbugs.net/view.php?id=529
#[cfg(not(target_os = "hermit"))]
{
#[cfg(unix)]
Expand Down