Skip to content

unix: document unsafety for std sig{action,altstack} #127843

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bors merged 5 commits into from
Jul 20, 2024
Merged

unix: document unsafety for std sig{action,altstack} #127843

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
9e354da
unix: Unsafe-wrap stack_overflow::signal_handler
workingjubilee Jul 17, 2024
357ba1f
unix: lift init of sigaltstack before sigaction
workingjubilee Jul 17, 2024
fa628ce
unix: Unsafe-wrap stack_overflow::cleanup
workingjubilee Jul 17, 2024
c1740ee
unix: Unsafe-wrap stack_overflow::{drop,make}_handler
workingjubilee Jul 17, 2024
529fcbc
unix: acquire-load NEED_ALTSTACK
workingjubilee Jul 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
unix: Unsafe-wrap stack_overflow::cleanup 
Editorialize on the wisdom of this as we do.
  • Loading branch information
@workingjubilee
workingjubilee committed Jul 18, 2024
commit fa628ceaff4e24fad699cc651cc6e7d521b642a9
7 changes: 6 additions & 1 deletion library/std/src/sys/pal/unix/stack_overflow.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -155,8 +155,13 @@ mod imp {
}
}

/// # Safety
/// Must be called only once
#[forbid(unsafe_op_in_unsafe_fn)]
pub unsafe fn cleanup() {
drop_handler(MAIN_ALTSTACK.load(Ordering::Relaxed));
// FIXME: I probably cause more bugs than I'm worth!
// see https://github.com/rust-lang/rust/issues/111272
unsafe { drop_handler(MAIN_ALTSTACK.load(Ordering::Relaxed)) };
}

unsafe fn get_stack() -> libc::stack_t {
Expand Down