Skip to content

Add File constructors that return files wrapped with a buffer #130803

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bors merged 4 commits into from
Sep 25, 2024
Merged

Add File constructors that return files wrapped with a buffer #130803

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ee129b1
Add `File::open_buffered` and `create_buffered`
cuviper Sep 24, 2024
1e9a50d
Pre-allocate buffers in `File::open_buffered` and `create_buffered`
cuviper Sep 24, 2024
0999b01
Dogfood `feature(file_buffered)`
cuviper Sep 24, 2024
458537e
Add a tracking issue for `file_buffered`
cuviper Sep 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Add a tracking issue for file_buffered
  • Loading branch information
@cuviper
cuviper committed Sep 24, 2024
commit 458537ebc0e7d893103e03450f8830061bab1b2d
4 changes: 2 additions & 2 deletions library/std/src/fs.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -405,7 +405,7 @@ impl File {
/// Ok(())
/// }
/// ```
#[unstable(feature = "file_buffered", issue = "none")]
#[unstable(feature = "file_buffered", issue = "130804")]
pub fn open_buffered<P: AsRef<Path>>(path: P) -> io::Result<io::BufReader<File>> {
// Allocate the buffer *first* so we don't affect the filesystem otherwise.
let buffer = io::BufReader::<Self>::try_new_buffer()?;
Expand Down Expand Up @@ -473,7 +473,7 @@ impl File {
/// Ok(())
/// }
/// ```
#[unstable(feature = "file_buffered", issue = "none")]
#[unstable(feature = "file_buffered", issue = "130804")]
pub fn create_buffered<P: AsRef<Path>>(path: P) -> io::Result<io::BufWriter<File>> {
// Allocate the buffer *first* so we don't affect the filesystem otherwise.
let buffer = io::BufWriter::<Self>::try_new_buffer()?;
Expand Down