Skip to content

Tweak E0277 output when a candidate is available #132147

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bors merged 8 commits into from
Nov 2, 2024
Merged

Tweak E0277 output when a candidate is available #132147

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
b7fc1a7
Add trait diff highlighting logic and use it in E0277
estebank Oct 24, 2024
7b9105d
Trim output of E0277 in some cases
estebank Oct 24, 2024
c6017ba
Fix type shortening writing to file
estebank Oct 25, 2024
86b5965
Use `short_ty_string`
estebank Oct 25, 2024
092ecca
Point at tail expression on rpit E0277
estebank Oct 25, 2024
1a0c502
On long E0277 primary span label, move it to a `help`
estebank Oct 25, 2024
143b072
Account for negative bounds in E0277 note and suggestion
estebank Oct 25, 2024
7e0d3ed
fix tests
estebank Nov 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Use short_ty_string
  • Loading branch information
@estebank
estebank committed Nov 2, 2024
commit 86b59656081d2dd03ef42d9d30d7141b1fc3b5f1
4 changes: 3 additions & 1 deletion compiler/rustc_trait_selection/src/error_reporting/traits/fulfillment_errors.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1872,7 +1872,9 @@ impl<'a, 'tcx> TypeErrCtxt<'a, 'tcx> {
StringPart::normal(" implemented for `"),
]);
if types_content.0 == types_content.1 {
msg.push(StringPart::normal(obligation_trait_ref.self_ty().to_string()));
let ty =
self.tcx.short_ty_string(obligation_trait_ref.self_ty(), &mut None);
msg.push(StringPart::normal(ty));
} else {
msg.extend(types.0.0);
}
Expand Down