Skip to content

Conversation

Zalathar
Copy link
Contributor

Known-bug test for keyword_idents lint not propagating to other files when configured via attribute (#132218).

@rustbot
Copy link
Collaborator

rustbot commented Oct 28, 2024

r? @TaKO8Ki

rustbot has assigned @TaKO8Ki.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Oct 28, 2024
@jieyouxu jieyouxu added L-keyword_idents_2018 Lint: keyword_idents_2018 L-keyword_idents_2024 Lint: keyword_idents_2024 L-keyword_idents Lint group: keyword_idents labels Oct 28, 2024
Copy link
Member

@jieyouxu jieyouxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@jieyouxu
Copy link
Member

r? jieyouxu
@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Oct 28, 2024

📌 Commit dfafbc4 has been approved by jieyouxu

It is now in the queue for this repository.

@rustbot rustbot assigned jieyouxu and unassigned TaKO8Ki Oct 28, 2024
@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 28, 2024
bors added a commit to rust-lang-ci/rust that referenced this pull request Oct 28, 2024
…iaskrgr

Rollup of 4 pull requests

Successful merges:

 - rust-lang#131391 (Stabilize `isqrt` feature)
 - rust-lang#132248 (rustc_transmute: Directly use types from rustc_abi)
 - rust-lang#132252 (compiler: rename LayoutS to LayoutData)
 - rust-lang#132253 (Known-bug test for `keyword_idents` lint not propagating to other files)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 2ca9b2c into rust-lang:master Oct 28, 2024
6 checks passed
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Oct 28, 2024
Rollup merge of rust-lang#132253 - Zalathar:keyword-idents-bug, r=jieyouxu

Known-bug test for `keyword_idents` lint not propagating to other files

Known-bug test for `keyword_idents` lint not propagating to other files when configured via attribute (rust-lang#132218).
@rustbot rustbot added this to the 1.84.0 milestone Oct 28, 2024
@Zalathar Zalathar deleted the keyword-idents-bug branch October 28, 2024 22:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
L-keyword_idents Lint group: keyword_idents L-keyword_idents_2018 Lint: keyword_idents_2018 L-keyword_idents_2024 Lint: keyword_idents_2024 S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants