Skip to content

codegen: store ScalarPair via memset when one side is undef and the other side can be memset #135335

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bors merged 4 commits into from
Jan 21, 2025
Merged

codegen: store ScalarPair via memset when one side is undef and the other side can be memset #135335

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
8876cf7
Also generate undef scalars and scalar pairs
oli-obk Jan 10, 2025
964c58a
Ensure we always get a constant, even without mir opts
oli-obk Jan 21, 2025
dfa4c01
Treat undef bytes as equal to any other byte
oli-obk Jan 8, 2025
8f5f5e5
Add more tests
oli-obk Jan 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Ensure we always get a constant, even without mir opts
  • Loading branch information
@oli-obk
oli-obk committed Jan 21, 2025
commit 964c58a7d96d4cd2dbda8fb40ff0f15ef10b78e3
2 changes: 1 addition & 1 deletion tests/codegen/slice-init.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,7 @@ pub fn option_none_init() -> [Option<u8>; N] {
// CHECK-NOT: switch
// CHECK: icmp
// CHECK-NOT: call void @llvm.memset.p0
[None; N]
[const { None }; N]
}

// Use an opaque function to prevent rustc from removing useless drops.
Expand Down