Skip to content
Closed
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
60 commits
Select commit Hold shift + click to select a range
547eaca
Convert `ShardedHashMap` to use `hashbrown::HashTable`
cuviper Feb 27, 2025
01795b1
change definitely non-productive cycles to error
lcnr Feb 27, 2025
18809a2
keep inductive cycles as ambig in coherence
lcnr Feb 28, 2025
36efaf8
normalize away `-Wlinker-messages` wrappers from `rust-lld` rmake test
lqd Mar 5, 2025
b2de19e
Update bootstrap to edition 2024
Kobzol Feb 25, 2025
6a38322
Rename print_something to should_render
compiler-errors Mar 5, 2025
279377f
Fix pretty printing of parsed attrs in hir_pretty
compiler-errors Mar 5, 2025
f525b17
Remove AdtFlags::IS_ANONYMOUS and Copy/Clone condition for anonymous ADT
compiler-errors Mar 10, 2025
b827087
add tracking issue for unqualified_local_imports
RalfJung Mar 10, 2025
02bb2d4
Disable CFI for weakly linked syscalls
1c3t3a Mar 4, 2025
e5dc1e3
Add comments for #[no_sanitize(cfi)] in stdlib
1c3t3a Mar 10, 2025
fb9ce02
Limit formatting width and precision to 16 bits.
m-ou-se Feb 12, 2025
4374d54
Update tests.
m-ou-se Feb 12, 2025
ce512c2
Fix rust-analyzer for 16-bit fmt width and precision.
m-ou-se Feb 12, 2025
7677567
Remove unnecessary semicolon.
m-ou-se Feb 28, 2025
2647cf1
Add #[track_caller] to from_usize.
m-ou-se Feb 28, 2025
7ca7675
Make all keys explicit in citool
Kobzol Feb 27, 2025
112f7b0
make precise capturing args in rustdoc Json typed
Kohei316 Mar 2, 2025
0412507
Move job handling to a separate module
Kobzol Mar 10, 2025
2ce0205
Share implementation of expr_u{16,32,size}.
m-ou-se Mar 10, 2025
3326a9f
Allow using glob aliases for custom try jobs
Kobzol Mar 10, 2025
06d86cd
Modify try-job documentation
Kobzol Mar 10, 2025
dfef1a7
Handle backticks in try job patterns
Kobzol Mar 10, 2025
16c08f6
Ignore job duplicates
Kobzol Mar 10, 2025
bf58a35
stabilize `ci_rustc_if_unchanged_logic` test for local environments
onur-ozkan Mar 8, 2025
32e0ce2
remove rls support from bootstrap
onur-ozkan Mar 10, 2025
733cbb5
remove rls specific parts from tidy and build-manifest
onur-ozkan Mar 10, 2025
91f8a40
remove rls source from the repository
onur-ozkan Mar 10, 2025
a657aeb
add change entry for rls removal
onur-ozkan Mar 10, 2025
5d4ff50
Update books
rustbot Mar 10, 2025
dcf6137
use next_back() instead of last() on DoubleEndedIterator
matthiaskrgr Mar 10, 2025
e337d87
Add powerpc64le maintainers
daltenty Mar 7, 2025
d75c973
main.js: insertAfter needs non-root referenceNode
lolbinarycat Mar 10, 2025
93161f5
main.js: don't set mouseMovedAfterSearch, as it is never read
lolbinarycat Mar 10, 2025
cf7f3cf
main.js: give type signatures to a few helper functions
lolbinarycat Mar 10, 2025
da5da99
main.js: handleEscape and handleShortcut accept KeyboardEvent
lolbinarycat Mar 10, 2025
6622111
main.js: always refer to searchState through window.searchState
lolbinarycat Mar 10, 2025
f5efd2a
main.js(isDisplayed): coerce truthy values to boolean
lolbinarycat Mar 10, 2025
ab180c2
main.js: handle document.activeElement being null
lolbinarycat Mar 10, 2025
2e1c8f0
rustdoc.d.ts: window.SIDEBAR_ITEMS may exist.
lolbinarycat Mar 10, 2025
749b6bf
rustdoc.d.ts: add window.{register_implementors,pending_implementors}
lolbinarycat Mar 10, 2025
7421546
main.js: typecheck things related to window.register_type_impls
lolbinarycat Mar 10, 2025
20bac26
main.js: remove searchState from globals.
lolbinarycat Mar 10, 2025
fb3d9ce
Rollup merge of #126856 - onur-ozkan:remove-rls, r=clubby789
jieyouxu Mar 10, 2025
12f29ff
Rollup merge of #136932 - m-ou-se:fmt-width-precision-u16, r=scottmcm
jieyouxu Mar 10, 2025
4e80159
Rollup merge of #137314 - lcnr:cycles-with-unknown-kind, r=compiler-e…
jieyouxu Mar 10, 2025
5923d2c
Rollup merge of #137612 - Kobzol:bootstrap-2024, r=onur-ozkan
jieyouxu Mar 10, 2025
5763e83
Rollup merge of #137701 - cuviper:sharded-hashtable, r=fmease
jieyouxu Mar 10, 2025
002b97a
Rollup merge of #138002 - 1c3t3a:fix-std-cfi-violation, r=rcvalle
jieyouxu Mar 10, 2025
4cbf318
Rollup merge of #138052 - lqd:lld-linker-messages, r=jieyouxu
jieyouxu Mar 10, 2025
de3720b
Rollup merge of #138063 - compiler-errors:improve-attr-unpretty, r=jd…
jieyouxu Mar 10, 2025
caf177d
Rollup merge of #138109 - Kohei316:feat/rust-doc-precise-capturing-ar…
jieyouxu Mar 10, 2025
41fc858
Rollup merge of #138147 - daltenty:patch-1, r=jieyouxu
jieyouxu Mar 10, 2025
f6b7134
Rollup merge of #138245 - onur-ozkan:ci-rustc-test-fix, r=jieyouxu
jieyouxu Mar 10, 2025
7956fc6
Rollup merge of #138296 - compiler-errors:deanonymous, r=lcnr
jieyouxu Mar 10, 2025
1a275d7
Rollup merge of #138300 - RalfJung:unqualified-local-imports, r=jieyouxu
jieyouxu Mar 10, 2025
8d3416e
Rollup merge of #138307 - Kobzol:citool-alias, r=marcoieni
jieyouxu Mar 10, 2025
4cbeefb
Rollup merge of #138313 - rustbot:docs-update, r=ehuss
jieyouxu Mar 10, 2025
7742eda
Rollup merge of #138315 - matthiaskrgr:nextback, r=fmease
jieyouxu Mar 10, 2025
0b4f8df
Rollup merge of #138318 - lolbinarycat:rustdoc-js-less-expect-error-p…
jieyouxu Mar 10, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Handle backticks in try job patterns
  • Loading branch information
Kobzol committed Mar 10, 2025
commit dfef1a7b5ab07617d3c5a595f3764bdcc01ef23e
11 changes: 9 additions & 2 deletions src/ci/citool/src/main.rs
Original file line number Diff line number Diff line change
Expand Up @@ -46,13 +46,20 @@ impl GitHubContext {
}
}

/// Tries to parse patterns of CI jobs that should be executed in the form of
/// Tries to parse patterns of CI jobs that should be executed
/// from the commit message of the passed GitHub context
///
/// They can be specified in the form of
/// try-job: <job-pattern>
/// from the commit message of the passed GitHub context.
/// or
/// try-job: `<job-pattern>`
/// (to avoid GitHub rendering the glob patterns as Markdown)
fn get_try_job_patterns(&self) -> Vec<String> {
if let Some(ref msg) = self.commit_message {
msg.lines()
.filter_map(|line| line.trim().strip_prefix("try-job: "))
// Strip backticks if present
.map(|l| l.trim_matches('`'))
.map(|l| l.trim().to_string())
.collect()
} else {
Expand Down
27 changes: 16 additions & 11 deletions src/doc/rustc-dev-guide/src/tests/ci.md
Original file line number Diff line number Diff line change
Expand Up @@ -133,29 +133,34 @@ There are several use-cases for try builds:
Again, a working compiler build is needed for this, which can be produced by
the [dist-x86_64-linux] CI job.
- Run a specific CI job (e.g. Windows tests) on a PR, to quickly test if it
passes the test suite executed by that job. You can select which CI jobs will
be executed in the try build by adding lines containing `try-job:
<job patter>` to the PR description. All such specified jobs will be executed
in the try build once the `@bors try` command is used on the PR. If no try
jobs are specified in this way, the jobs defined in the `try` section of
[`jobs.yml`] will be executed by default. Each pattern can either be an exact
name of a job or a glob pattern that matches multiple jobs, for example
`*msvc*` or `*-alt`. You can start at most 20 jobs in a single try build.
passes the test suite executed by that job.

You can select which CI jobs will
be executed in the try build by adding lines containing `try-job:
<job pattern>` to the PR description. All such specified jobs will be executed
in the try build once the `@bors try` command is used on the PR. If no try
jobs are specified in this way, the jobs defined in the `try` section of
[`jobs.yml`] will be executed by default.

Each pattern can either be an exact name of a job or a glob pattern that matches multiple jobs,
for example `*msvc*` or `*-alt`. You can start at most 20 jobs in a single try build. When using
glob patterns, you might want to wrap them in backticks (`` ` ``) to avoid GitHub rendering
the pattern as Markdown.

> **Using `try-job` PR description directives**
>
> 1. Identify which set of try-jobs you would like to exercise. You can
> find the name of the CI jobs in [`jobs.yml`].
>
> 2. Amend PR description to include (usually at the end of the PR description)
> e.g.
> 2. Amend PR description to include a set of patterns (usually at the end
> of the PR description), for example:
>
> ```text
> This PR fixes #123456.
>
> try-job: x86_64-msvc
> try-job: test-various
> try-job: *-alt
> try-job: `*-alt`
> ```
>
> Each `try-job` pattern must be on its own line.
Expand Down