Skip to content

Improve hir pretty printing #140606

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bors merged 7 commits into from
May 3, 2025
Merged

Improve hir pretty printing #140606

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
882c74d
Remove fake `BoxMarker`s.
nnethercote Apr 29, 2025
3896ad0
Remove opaque type printing.
nnethercote Apr 29, 2025
760cf8d
Fix hir pretty-printing of `global_asm!`.
nnethercote Apr 29, 2025
aa7bb1c
Enable `BoxMarker` drop checking.
nnethercote Apr 29, 2025
e1a177b
Improve hir pretty-printing of attributes.
nnethercote Apr 30, 2025
809e5b5
Fix some hir pretty-printing over-indenting.
nnethercote Apr 30, 2025
9af0842
Avoid an indent for labelled loops.
nnethercote Apr 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Remove opaque type printing. 
As far as I can tell, this code is not actually reachable.
  • Loading branch information
@nnethercote
nnethercote committed May 2, 2025
commit 3896ad0acd53fa62cab711d20af8dec1f3e944a1
10 changes: 1 addition & 9 deletions compiler/rustc_hir_pretty/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -183,7 +183,7 @@ impl<'a> State<'a> {
Node::Ty(a) => self.print_type(a),
Node::AssocItemConstraint(a) => self.print_assoc_item_constraint(a),
Node::TraitRef(a) => self.print_trait_ref(a),
Node::OpaqueTy(o) => self.print_opaque_ty(o),
Node::OpaqueTy(_) => panic!("cannot print Node::OpaqueTy"),
Node::Pat(a) => self.print_pat(a),
Node::TyPat(a) => self.print_ty_pat(a),
Node::PatField(a) => self.print_patfield(a),
Expand Down Expand Up @@ -764,14 +764,6 @@ impl<'a> State<'a> {
self.print_path(t.path, false);
}

fn print_opaque_ty(&mut self, o: &hir::OpaqueTy<'_>) {
// FIXME(nnethercote): `cb` and `ib` are unclosed
let (_cb, _ib) = self.head("opaque");
self.word("{");
self.print_bounds("impl", o.bounds);
self.word("}");
}

fn print_formal_generic_params(&mut self, generic_params: &[hir::GenericParam<'_>]) {
if !generic_params.is_empty() {
self.word("for");
Expand Down