Allow &raw [mut | const] for union field in safe code
#141469
Merged
+132
−12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Failed to set assignee to
|
rustbot
added
S-waiting-on-review
|
cc @RalfJung |
fmease
added
the
I-lang-nominated
Kivooeo
changed the title
&raw [mut | const] for union field in safe
fmease
added
the
needs-fcp
|
Uh, the unsafety checker is not actually code I know very well, sorry. |
RalfJung
reviewed
May 23, 2025
RalfJung
reviewed
May 23, 2025
The macros just expand to |
This comment has been minimized.
This comment has been minimized.
|
I will debug this later today but this is very weird |
RalfJung
reviewed
May 24, 2025
fmease
added
T-lang
Kivooeo
force-pushed
the
remove-usnsafegate
branch
from
b006128 to
43892d3
Compare
This comment has been minimized.
This comment has been minimized.
Kivooeo
force-pushed
the
remove-usnsafegate
branch
from
b60d3ff to
fc03435
Compare
This comment has been minimized.
This comment has been minimized.
Kivooeo
force-pushed
the
remove-usnsafegate
branch
from
9ccf35d to
cde9fa0
Compare
|
@rustbot ready |
rustbot
added
S-waiting-on-review
rust-cloud-vms
bot
force-pushed
the
remove-usnsafegate
branch
from
4024f37 to
23f1767
Compare
RalfJung
changed the title
&raw [mut | const] for union field in safe&raw [mut | const] for union field in safe code
|
@rfcbot reviewed |
rust-rfcbot
added
final-comment-period
|
🔔 This is now entering its final comment period, as per the review above. 🔔 |
|
@rfcbot reviewed |
|
r=me when FCP is over. |
traviscross
added
I-lang-radar
rust-rfcbot
added
finished-final-comment-period
|
The final comment period, with a disposition to merge, as per the review above, is now complete. As the automated representative of the governance process, I would like to thank the author for their work and everyone else who contributed. This will be merged soon. |
traviscross
added
the
relnotes
|
@bors r=compiler-errors |
bors
added
S-waiting-on-bors
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Sep 28, 2025
…iler-errors Allow `&raw [mut | const]` for union field in safe code fixes rust-lang#141264 r? `@Veykril` Unresolved questions: - [x] Any edge cases? - [x] How this works with rust-analyzer (because all I've did is prevent compiler from emitting error in `&raw` context) (rust-lang/rust-analyzer#19867) - [x] Should we allow `addr_of!` and `addr_of_mut!` as well? In current version they both (`&raw` and `addr_of!`) are allowed (They are the same) - [x] Is chain of union fields is a safe? (Yes)
bors
added a commit
that referenced
this pull request
Sep 28, 2025
Rollup of 6 pull requests Successful merges: - #140482 (std::net: update tcp deferaccept delay type to Duration.) - #141469 (Allow `&raw [mut | const]` for union field in safe code) - #144197 (TypeTree support in autodiff) - #146675 (Allow shared access to `Exclusive<T>` when `T: Sync`) - #147113 (Reland "Add LSX accelerated implementation for source file analysis") - #147120 (Fix --extra-checks=spellcheck to prevent cargo install every time) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
that referenced
this pull request
Sep 28, 2025
Rollup merge of #141469 - Kivooeo:remove-usnsafegate, r=compiler-errors Allow `&raw [mut | const]` for union field in safe code fixes #141264 r? ``@Veykril`` Unresolved questions: - [x] Any edge cases? - [x] How this works with rust-analyzer (because all I've did is prevent compiler from emitting error in `&raw` context) (rust-lang/rust-analyzer#19867) - [x] Should we allow `addr_of!` and `addr_of_mut!` as well? In current version they both (`&raw` and `addr_of!`) are allowed (They are the same) - [x] Is chain of union fields is a safe? (Yes)
github-actions bot
pushed a commit
to rust-lang/miri
that referenced
this pull request
Sep 29, 2025
Rollup of 6 pull requests Successful merges: - rust-lang/rust#140482 (std::net: update tcp deferaccept delay type to Duration.) - rust-lang/rust#141469 (Allow `&raw [mut | const]` for union field in safe code) - rust-lang/rust#144197 (TypeTree support in autodiff) - rust-lang/rust#146675 (Allow shared access to `Exclusive<T>` when `T: Sync`) - rust-lang/rust#147113 (Reland "Add LSX accelerated implementation for source file analysis") - rust-lang/rust#147120 (Fix --extra-checks=spellcheck to prevent cargo install every time) r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #141264
r? @Veykril
Unresolved questions:
&rawcontext) (Allow&raw [mut | const]for union field rust-analyzer#19867)addr_of!andaddr_of_mut!as well? In current version they both (&rawandaddr_of!) are allowed (They are the same)