Skip to content

add reference id to test, and fix filename #143314

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 15, 2025
Merged

add reference id to test, and fix filename #143314

merged 1 commit into from
Sep 15, 2025

Conversation

tshepang
Copy link
Member

@tshepang tshepang commented Jul 2, 2025 •
edited
Loading

Noticed the filename is wrong, then took advantage of being there by adding Reference id

@rustbot
Copy link
Collaborator

rustbot commented Jul 2, 2025

r? @compiler-errors

rustbot has assigned @compiler-errors.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jul 2, 2025
@compiler-errors
Copy link
Member

please squash this into one commit; there's no need to make this two commits if they're both just tiny tweaks.

@compiler-errors
Copy link
Member

@rustbot author

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 2, 2025
@compiler-errors
Copy link
Member

compiler-errors commented Jul 2, 2025 •
edited
Loading

Also please adjust the description and PR title to actually reflect what this PR does. I think out of the rename and adding a reference ID, the latter is actually the more important part of this PR, so it would be nice if that had been mentioned.

Because right now the title is very vague.

@tshepang tshepang changed the title fix filename for test add reference id to test, and fix filename Jul 3, 2025
@tshepang
Copy link
Member Author

tshepang commented Jul 3, 2025

squashed, though I thought the changes were distinct enough to deserve separate commits

@karolzwolak karolzwolak added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Aug 24, 2025
@compiler-errors
Copy link
Member

though I thought the changes were distinct enough to deserve separate commits

Nah, these are tiny changes. Commits are distinct when they contain significant distinct changes.

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Sep 14, 2025

📌 Commit c40e004 has been approved by compiler-errors

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 14, 2025
@matthiaskrgr matthiaskrgr mentioned this pull request Sep 15, 2025
Merged
bors added a commit that referenced this pull request Sep 15, 2025
@bors
Auto merge of #146572 - matthiaskrgr:rollup-gotklb6, r=matthiaskrgr
d1ed52b 
Rollup of 8 pull requests

Successful merges:

 - #143314 (add reference id to test, and fix filename)
 - #146284 (Remove `div_rem` from `core::num::bignum`)
 - #146416 (Tidy dependency checks cleanups + QoL)
 - #146471 (bootstrap: Show target in "No such target exists" message)
 - #146478 (Improve `core::fmt` coverage)
 - #146480 (tests: update new test to accept new lifetime format)
 - #146488 (Improve `core::ptr` coverage)
 - #146501 (compiletest: Fix `--exact` test filtering)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit f96bc5c into rust-lang:master Sep 15, 2025
11 checks passed
@rustbot rustbot added this to the 1.92.0 milestone Sep 15, 2025
rust-timer added a commit that referenced this pull request Sep 15, 2025
@rust-timer
Unrolled build for #143314
324b3ad 
Rollup merge of #143314 - tshepang:fix-filename, r=compiler-errors

add reference id to test, and fix filename

Noticed the filename is wrong, then took advantage of being there by adding Reference id
@tshepang tshepang deleted the fix-filename branch September 15, 2025 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@compiler-errors compiler-errors

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.92.0
Development

Successfully merging this pull request may close these issues.
5 participants
@tshepang @rustbot @compiler-errors @bors @karolzwolak