[EXPERIMENT] Introduce TypingMode::Codegen to avoid layout cycles

[cjgillot]

r? @ghost

[cjgillot]

@bors try @rust-timer queue

[rust-bors]

☀️ Try build successful (CI)
Build commit: 34dd67f (34dd67f42f0f2050c773b332e2dd333618c22743, parent: cd7cbe818e4a66d46fe2df993d1b8518eba8a5cd)

[rust-timer]

Finished benchmarking commit (34dd67f): comparison URL.

Overall result: ❌ regressions - please read the text below

Benchmarking this pull request means it may be perf-sensitive – we'll automatically label it not fit for rolling up. You can override this, but we strongly advise not to, due to possible changes in compiler perf.

Next Steps: If you can justify the regressions found in this try perf run, please do so in sufficient writing along with @rustbot label: +perf-regression-triaged. If not, please fix the regressions and do another perf run. If its results are neutral or positive, the label will be automatically removed.

@bors rollup=never
@rustbot label: -S-waiting-on-perf +perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

	mean	range	count
Regressions ❌ (primary)	0.5%	[0.2%, 3.3%]	58
Regressions ❌ (secondary)	1.8%	[0.0%, 19.4%]	58
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-0.2%	[-0.3%, -0.0%]	4
All ❌✅ (primary)	0.5%	[0.2%, 3.3%]	58

Max RSS (memory usage)

Results (primary 1.4%, secondary 4.3%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	1.7%	[0.5%, 7.3%]	17
Regressions ❌ (secondary)	5.4%	[1.2%, 12.3%]	6
Improvements ✅ (primary)	-1.3%	[-1.4%, -1.3%]	2
Improvements ✅ (secondary)	-2.3%	[-2.3%, -2.3%]	1
All ❌✅ (primary)	1.4%	[-1.4%, 7.3%]	19

Cycles

Results (primary 2.9%, secondary 4.5%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	2.9%	[2.9%, 2.9%]	1
Regressions ❌ (secondary)	5.3%	[2.1%, 12.0%]	12
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-4.0%	[-4.0%, -4.0%]	1
All ❌✅ (primary)	2.9%	[2.9%, 2.9%]	1

Binary size

Results (primary 0.1%, secondary -1.0%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	0.4%	[0.1%, 0.6%]	2
Regressions ❌ (secondary)	0.3%	[0.1%, 0.4%]	3
Improvements ✅ (primary)	-0.0%	[-0.0%, -0.0%]	3
Improvements ✅ (secondary)	-1.8%	[-7.1%, -0.1%]	5
All ❌✅ (primary)	0.1%	[-0.0%, 0.6%]	5

Bootstrap: 469.562s -> 472.464s (0.62%)
Artifact size: 377.55 MiB -> 377.67 MiB (0.03%)

[cjgillot]

@bors try @rust-timer queue

[rust-bors]

☀️ Try build successful (CI)
Build commit: 4e9488c (4e9488c147d4057600076145eccb670b130147d5, parent: 2e2642e641a941f0a1400c7827fd89aa86fef8f4)

[rust-timer]

Finished benchmarking commit (4e9488c): comparison URL.

Overall result: ❌ regressions - please read the text below

Benchmarking this pull request means it may be perf-sensitive – we'll automatically label it not fit for rolling up. You can override this, but we strongly advise not to, due to possible changes in compiler perf.

Next Steps: If you can justify the regressions found in this try perf run, please do so in sufficient writing along with @rustbot label: +perf-regression-triaged. If not, please fix the regressions and do another perf run. If its results are neutral or positive, the label will be automatically removed.

@bors rollup=never
@rustbot label: -S-waiting-on-perf +perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

	mean	range	count
Regressions ❌ (primary)	0.4%	[0.2%, 0.9%]	23
Regressions ❌ (secondary)	1.5%	[0.1%, 9.7%]	59
Improvements ✅ (primary)	-1.6%	[-1.6%, -1.6%]	1
Improvements ✅ (secondary)	-0.3%	[-0.3%, -0.3%]	2
All ❌✅ (primary)	0.4%	[-1.6%, 0.9%]	24

Max RSS (memory usage)

Results (primary 1.7%, secondary 5.0%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	1.9%	[0.5%, 7.5%]	19
Regressions ❌ (secondary)	6.6%	[0.4%, 12.9%]	5
Improvements ✅ (primary)	-1.3%	[-1.3%, -1.3%]	1
Improvements ✅ (secondary)	-2.8%	[-2.8%, -2.8%]	1
All ❌✅ (primary)	1.7%	[-1.3%, 7.5%]	20

Cycles

Results (secondary 2.7%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	4.2%	[2.1%, 10.2%]	8
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-3.0%	[-3.8%, -2.2%]	2
All ❌✅ (primary)	-	-	0

Binary size

Results (primary 0.0%, secondary -1.1%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	0.1%	[0.1%, 0.1%]	1
Regressions ❌ (secondary)	0.2%	[0.1%, 0.4%]	4
Improvements ✅ (primary)	-0.0%	[-0.0%, -0.0%]	3
Improvements ✅ (secondary)	-2.9%	[-6.8%, -0.0%]	3
All ❌✅ (primary)	0.0%	[-0.0%, 0.1%]	4

Bootstrap: 470.222s -> 472.094s (0.40%)
Artifact size: 377.51 MiB -> 377.42 MiB (-0.02%)

[bors]

☔ The latest upstream changes (presumably #145469) made this pull request unmergeable. Please resolve the merge conflicts.

[bors]

☔ The latest upstream changes (presumably #145384) made this pull request unmergeable. Please resolve the merge conflicts.

[rust-log-analyzer]

The job pr-check-2 failed! Check out the build log: (web) (plain enhanced) (plain)

Click to see the possible cause of the failure (guessed by this bot)

    |
250 |         let stalled_coroutines = match infcx.typing_mode() {
    |                                        ^^^^^^^^^^^^^^^^^^^ pattern `rustc_type_ir::TypingMode::Codegen` not covered
    |
note: `rustc_type_ir::TypingMode<next_solver::interner::DbInterner<'_>>` defined here
   --> /checkout/compiler/rustc_type_ir/src/infer_ctxt.rs:26:1
    |
 26 | pub enum TypingMode<I: Interner> {
    | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
...
 91 |     Codegen,
    |     ------- not covered
    = note: the matched value is of type `rustc_type_ir::TypingMode<next_solver::interner::DbInterner<'_>>`
help: ensure that all possible cases are being handled by adding a match arm with a wildcard pattern or an explicit pattern as shown
    |
257 ~             | TypingMode::PostAnalysis => return Default::default(),
258 ~             rustc_type_ir::TypingMode::Codegen => todo!(),
    |

---
    |
714 |         match self.typing_mode_unchecked() {
    |               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ pattern `rustc_type_ir::TypingMode::Codegen` not covered
    |
note: `rustc_type_ir::TypingMode<next_solver::interner::DbInterner<'_>>` defined here
   --> /checkout/compiler/rustc_type_ir/src/infer_ctxt.rs:26:1
    |
 26 | pub enum TypingMode<I: Interner> {
    | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
...
 91 |     Codegen,
    |     ------- not covered
    = note: the matched value is of type `rustc_type_ir::TypingMode<next_solver::interner::DbInterner<'_>>`
help: ensure that all possible cases are being handled by adding a match arm with a wildcard pattern or an explicit pattern as shown
    |
720 ~             TypingMode::PostBorrowckAnalysis { defined_opaque_types } => unimplemented!(),
721 ~             rustc_type_ir::TypingMode::Codegen => todo!(),
    |

---
     |
1004 |     match infcx.typing_mode() {
     |           ^^^^^^^^^^^^^^^^^^^ pattern `rustc_type_ir::TypingMode::Codegen` not covered
     |
note: `rustc_type_ir::TypingMode<next_solver::interner::DbInterner<'_>>` defined here
    --> /checkout/compiler/rustc_type_ir/src/infer_ctxt.rs:26:1
     |
  26 | pub enum TypingMode<I: Interner> {
     | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
...
  91 |     Codegen,
     |     ------- not covered
     = note: the matched value is of type `rustc_type_ir::TypingMode<next_solver::interner::DbInterner<'_>>`
help: ensure that all possible cases are being handled by adding a match arm with a wildcard pattern or an explicit pattern as shown
     |
1010 ~         TypingMode::PostAnalysis => {},
1011 +         rustc_type_ir::TypingMode::Codegen => todo!()
     |